Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 132333018: Revert of Reland r165710 "Replace RenderFullScreen with top layer" (Closed)

Created:
6 years, 10 months ago by falken
Modified:
6 years, 10 months ago
Reviewers:
esprehn
CC:
blink-reviews, zoltan1, dsinclair, sof, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, blink-layers+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, bemjb+rendering_chromium.org, Inactive
Visibility:
Public.

Description

Revert of Reland r165710 "Replace RenderFullScreen with top layer" (https://codereview.chromium.org/134753003/) Reason for revert: Looks like it's causing failures on: virtual/android/fullscreen/anonymous-block-merge-crash.html fullscreen/anonymous-block-merge-crash.html virtual/android/fullscreen/full-screen-iframe-legacy.html plugin-document-back-forward.html See: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/26047 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)/builds/17197 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28dbg%29/builds/11804 Original issue's description: > Reland r165710 "Replace RenderFullScreen with top layer" > > It broke browser_test OutOfProcessPPAPITest.Fullscreen by tripping an > assert reached by calling pluginWidget in HTMLPluginElement::detach > which causes a layout. The solution is to get the existing widget > without causing a layout. > > Original code review: https://codereview.chromium.org/139743005/ > > BUG=240576, 246077 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165904 TBR=esprehn@chromium.org NOTREECHECKS=true NOTRY=true BUG=240576, 246077 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+475 lines, -278 lines) Patch
M LayoutTests/TestExpectations View 3 chunks +3 lines, -12 lines 0 comments Download
D LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality.html View 1 chunk +0 lines, -105 lines 0 comments Download
D LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-is-in-top-layer.html View 1 chunk +0 lines, -40 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-placeholder.html View 1 chunk +73 lines, -0 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-placeholder-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-video-has-backdrop.html View 1 chunk +0 lines, -31 lines 0 comments Download
A LayoutTests/platform/linux/fullscreen/parent-flow-inline-with-block-child-expected.png View Binary file 0 comments Download
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/fullscreen.css View 1 chunk +1 line, -22 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +3 lines, -9 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.h View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 10 chunks +50 lines, -14 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/html/HTMLDialogElement.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDialogElement.cpp View 4 chunks +0 lines, -10 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 3 chunks +1 line, -16 lines 0 comments Download
A Source/core/rendering/RenderFullScreen.h View 1 chunk +60 lines, -0 lines 0 comments Download
A Source/core/rendering/RenderFullScreen.cpp View 1 chunk +189 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderVideo.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
falken
Created Revert of Reland r165710 "Replace RenderFullScreen with top layer"
6 years, 10 months ago (2014-01-28 11:15:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/132333018/1
6 years, 10 months ago (2014-01-28 11:16:11 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-01-28 11:16:44 UTC) #3
Message was sent while issue was closed.
Change committed as 165928

Powered by Google App Engine
This is Rietveld 408576698