Issue 1323263006: Merge to XFA: Remove unneeded checks for CPDF_Object::GetDict() return values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1323263006: Merge to XFA: Remove unneeded checks for CPDF_Object::GetDict() return values. (Closed)

Created:
5 years, 3 months ago by Lei Zhang

Modified:
5 years, 3 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Remove unneeded checks for CPDF_Object::GetDict() return values. CPDF_Object::GetDict() always returns a valid pointer for dictionaries. R=tsepez@chromium.org TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1317733007 . (cherry picked from commit 2f740a8bd61c1c198796dd5e2124d007267f9c1a) Committed: https://pdfium.googlesource.com/pdfium/+/e61b6e58c9c535ca097b9819c333b65825e0c64e

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -9 lines)			Patch
	M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View		2 chunks	+6 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

5 years, 3 months ago (2015-09-08 17:36:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e61b6e58c9c535ca097b9819c333b65825e0c64e (presubmit successful).