Remove unneeded checks for CPDF_Object::GetDict() return values.

Remove unneeded checks for CPDF_Object::GetDict() return values.

CPDF_Object::GetDict() always returns a valid pointer for dictionaries.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/2f740a8bd61c1c198796dd5e2124d007267f9c1a

[Lei Zhang, 2015-09-04 21:03:11]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2015-09-04 21:10:40]

https://codereview.chromium.org/1317733007/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1317733007/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:4111: CPDF_Dictionary*
pTrailerDict = pTrailer->GetDict();
Check is right above on line 4107.

https://codereview.chromium.org/1317733007/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:4232: CPDF_Dictionary* pDict
= pPage->GetDict();
Check on line 4226.

[Tom Sepez, 2015-09-08 16:04:00]

LGTM.

In the past, I've toyed with the idea of adding ToDict() methods and such to
check the type then cast.  Do we want to undertake this?

[Lei Zhang, 2015-09-08 17:16:54]

On 2015/09/08 16:04:00, Tom Sepez wrote:
> LGTM.
> 
> In the past, I've toyed with the idea of adding ToDict() methods and such to
> check the type then cast.  Do we want to undertake this?

Let's file a bug so it doesn't get dropped. Whoever gets around to get first...

[Lei Zhang, 2015-09-08 17:17:30]

Committed patchset #1 (id:1) manually as
2f740a8bd61c1c198796dd5e2124d007267f9c1a (presubmit successful).

[Tom Sepez, 2015-09-08 17:33:54]

On 2015/09/08 17:17:30, Lei Zhang wrote:
> Committed patchset #1 (id:1) manually as
> 2f740a8bd61c1c198796dd5e2124d007267f9c1a (presubmit successful).

https://code.google.com/p/pdfium/issues/detail?id=201 as followup.