Roll WebRTC 10010:10022, Libjingle 10011:10022

Roll WebRTC 10010:10022, Libjingle 10011:10022

WebRTC 10010:10022

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/ea85c10..a6e4fcd

Libjingle 10011:10022

Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/300c749..228d997

Committed: https://crrev.com/c912315bd1a2e2def25caf9366ecf2f2df284c93
Cr-Commit-Position: refs/heads/master@{#350347}

[Taylor_Brandstetter, 2015-09-04 18:31:50]

deadbeef@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Taylor_Brandstetter, 2015-09-04 18:31:50]

After https://codereview.webrtc.org/1246913005/ is submitted, I plan to merge
the webrtc roll with this CL. Besides method renaming, the only change that
impacts Chromoting is that "OnSignalingReady"/"SignalRequestSignaling" are
removed.

[Sergey Ulanov, 2015-09-04 18:37:32]

this change looks good, but you also want to update DEPS in the same CL to
actually roll webrtc.

Also please update description to make it clear you are rolling webrtc, see
https://codereview.chromium.org/1317563009/ for an example.

https://codereview.chromium.org/1323243006/diff/1/remoting/protocol/libjingle...
File remoting/protocol/libjingle_transport_factory.cc (right):

https://codereview.chromium.org/1323243006/diff/1/remoting/protocol/libjingle...
remoting/protocol/libjingle_transport_factory.cc:82: const cricket::Candidate&
candidate);
update indentation please

[Taylor_Brandstetter, 2015-09-04 18:58:59]

tools/roll_webrtc.py will handle updating the DEPS file (and generating an
accurate description). I just haven't done that yet, since the CL I want to roll
hasn't been submitted yet. Peter suggested taking this approach (getting a
preemptive LGTM), so that once the CL *is* submitted, I can get it rolled as
smoothly as possible.

https://codereview.chromium.org/1323243006/diff/1/remoting/protocol/libjingle...
File remoting/protocol/libjingle_transport_factory.cc (right):

https://codereview.chromium.org/1323243006/diff/1/remoting/protocol/libjingle...
remoting/protocol/libjingle_transport_factory.cc:82: const cricket::Candidate&
candidate);
On 2015/09/04 18:37:32, Sergey Ulanov wrote:
> update indentation please

Done.

[Sergey Ulanov, 2015-09-04 19:03:33]

I see, but my LGTM on this change doesn't matter because I assume
tools/roll_webrtc.py will create a separate CL. Feel free to TBR me on that
change.

On 2015/09/04 18:58:59, Taylor_Brandstetter wrote:
> tools/roll_webrtc.py will handle updating the DEPS file (and generating an
> accurate description). I just haven't done that yet, since the CL I want to
roll
> hasn't been submitted yet. Peter suggested taking this approach (getting a
> preemptive LGTM), so that once the CL *is* submitted, I can get it rolled as
> smoothly as possible.
> 
>
https://codereview.chromium.org/1323243006/diff/1/remoting/protocol/libjingle...
> File remoting/protocol/libjingle_transport_factory.cc (right):
> 
>
https://codereview.chromium.org/1323243006/diff/1/remoting/protocol/libjingle...
> remoting/protocol/libjingle_transport_factory.cc:82: const cricket::Candidate&
> candidate);
> On 2015/09/04 18:37:32, Sergey Ulanov wrote:
> > update indentation please
> 
> Done.

[Taylor_Brandstetter, 2015-09-04 19:21:10]

On 2015/09/04 19:03:33, Sergey Ulanov wrote:
> I see, but my LGTM on this change doesn't matter because I assume
> tools/roll_webrtc.py will create a separate CL. Feel free to TBR me on that
> change.
> 
> On 2015/09/04 18:58:59, Taylor_Brandstetter wrote:
> > tools/roll_webrtc.py will handle updating the DEPS file (and generating an
> > accurate description). I just haven't done that yet, since the CL I want to
> roll
> > hasn't been submitted yet. Peter suggested taking this approach (getting a
> > preemptive LGTM), so that once the CL *is* submitted, I can get it rolled as
> > smoothly as possible.
> > 
> >
>
https://codereview.chromium.org/1323243006/diff/1/remoting/protocol/libjingle...
> > File remoting/protocol/libjingle_transport_factory.cc (right):
> > 
> >
>
https://codereview.chromium.org/1323243006/diff/1/remoting/protocol/libjingle...
> > remoting/protocol/libjingle_transport_factory.cc:82: const
cricket::Candidate&
> > candidate);
> > On 2015/09/04 18:37:32, Sergey Ulanov wrote:
> > > update indentation please
> > 
> > Done.

Yes, the roll tool will create a special branch, but then I can just merge it
with this CL. That's what Peter originally did for
https://codereview.chromium.org/1278073004/#ps20001

[pthatcher2, 2015-09-04 19:24:42]

pthatcher@chromium.org changed reviewers:
+ pthatcher@chromium.org

[pthatcher2, 2015-09-04 19:24:42]

lgtm

[Sergey Ulanov, 2015-09-04 19:27:04]

On 2015/09/04 19:21:10, Taylor_Brandstetter wrote:

> Yes, the roll tool will create a special branch, but then I can just merge it
> with this CL. That's what Peter originally did for
> https://codereview.chromium.org/1278073004/#ps20001

I see. But then the tool will not update description for this CL. Please update
it before landing.

[Taylor_Brandstetter, 2015-09-04 19:28:42]

On 2015/09/04 19:27:04, Sergey Ulanov wrote:
> On 2015/09/04 19:21:10, Taylor_Brandstetter wrote:
> 
> > Yes, the roll tool will create a special branch, but then I can just merge
it
> > with this CL. That's what Peter originally did for
> > https://codereview.chromium.org/1278073004/#ps20001
> 
> I see. But then the tool will not update description for this CL. Please
update
> it before landing.

Will do.

[Taylor_Brandstetter, 2015-09-18 20:02:57]

The CQ bit was checked by deadbeef@chromium.org

[Taylor_Brandstetter, 2015-09-18 20:02:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, pthatcher@chromium.org
Link to the patchset: https://codereview.chromium.org/1323243006/#ps80001
(title: "Update DEPS")

[commit-bot: I haz the power, 2015-09-18 20:03:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323243006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323243006/80001

[commit-bot: I haz the power, 2015-09-18 20:30:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 20:30:40]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Taylor_Brandstetter, 2015-09-22 22:13:52]

The CQ bit was checked by deadbeef@chromium.org

[Taylor_Brandstetter, 2015-09-22 22:13:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, pthatcher@chromium.org
Link to the patchset: https://codereview.chromium.org/1323243006/#ps120001
(title: "Rolling again.")

[commit-bot: I haz the power, 2015-09-22 22:15:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323243006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323243006/120001

[Taylor_Brandstetter, 2015-09-22 22:20:00]

The CQ bit was unchecked by deadbeef@chromium.org

[Taylor_Brandstetter, 2015-09-22 22:27:55]

The CQ bit was checked by deadbeef@chromium.org

[Taylor_Brandstetter, 2015-09-22 22:27:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, pthatcher@chromium.org
Link to the patchset: https://codereview.chromium.org/1323243006/#ps140001
(title: "Removed DEPS that were being unintentionally modified by git merge")

[commit-bot: I haz the power, 2015-09-22 22:29:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323243006/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323243006/140001

[commit-bot: I haz the power, 2015-09-23 01:37:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 01:37:21]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Taylor_Brandstetter, 2015-09-23 01:45:27]

The CQ bit was checked by deadbeef@chromium.org

[Taylor_Brandstetter, 2015-09-23 01:46:20]

The CQ bit was unchecked by deadbeef@chromium.org

[tommi (sloooow) - chröme, 2015-09-23 08:10:55]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2015-09-23 08:11:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323243006/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323243006/140001

[commit-bot: I haz the power, 2015-09-23 18:26:35]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-09-23 18:36:02]

Patchset 8 (id:??) landed as
https://crrev.com/c912315bd1a2e2def25caf9366ecf2f2df284c93
Cr-Commit-Position: refs/heads/master@{#350347}