Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1278073004: Roll WebRTC 9687:9692, Libjingle 9690:9692 (Closed)

Created:
5 years, 4 months ago by pthatcher2
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependencies remoting has on GICE-related constants. Committed: https://crrev.com/5bc4564a8a3fc3f741170bf999ae34934c087a21 Cr-Commit-Position: refs/heads/master@{#345216}

Patch Set 1 #

Patch Set 2 : Fix remoting #

Patch Set 3 : remove roll part; keep only remoting part #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M remoting/client/plugin/pepper_port_allocator.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M remoting/protocol/chromium_port_allocator.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M remoting/protocol/libjingle_transport_factory.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M remoting/test/fake_port_allocator.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278073004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278073004/1
5 years, 4 months ago (2015-08-10 20:14:42 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-10 20:14:43 UTC) #4
pthatcher2
5 years, 4 months ago (2015-08-10 20:18:06 UTC) #6
magjed_chromium
lgtm
5 years, 4 months ago (2015-08-11 07:56:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278073004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278073004/20001
5 years, 4 months ago (2015-08-11 07:56:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/87049)
5 years, 4 months ago (2015-08-11 08:06:51 UTC) #11
magjed_chromium
dcaiafa@, can you review remoting/* files? The corresponding WebRTC CL for removing GICE is here ...
5 years, 4 months ago (2015-08-11 08:24:31 UTC) #13
dcaiafa
+ Sergey l-g-t-m but Sergey is the protocol/libjingle expert
5 years, 4 months ago (2015-08-21 00:07:59 UTC) #15
Sergey Ulanov
lgtm
5 years, 4 months ago (2015-08-21 00:24:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278073004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278073004/40001
5 years, 3 months ago (2015-08-24 23:27:16 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-08-25 00:19:27 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 00:20:15 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5bc4564a8a3fc3f741170bf999ae34934c087a21
Cr-Commit-Position: refs/heads/master@{#345216}

Powered by Google App Engine
This is Rietveld 408576698