DevTools: expose initial request priority in the Network panel UI

DevTools: expose initial request priority in the Network panel UI

BUG=522739
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201673

[caseq, 2015-09-02 18:35:16]

caseq@chromium.org changed reviewers:
+ alph@chromium.org, dgozman@chromium.org

[caseq, 2015-09-02 18:35:17]

This depens on https://codereview.chromium.org/1324073003/ for the
back-end/protocol part.

[alph, 2015-09-02 20:38:53]

lgtm

https://codereview.chromium.org/1323143005/diff/1/Source/devtools/front_end/n...
File Source/devtools/front_end/network/NetworkDataGridNode.js (right):

https://codereview.chromium.org/1323143005/diff/1/Source/devtools/front_end/n...
Source/devtools/front_end/network/NetworkDataGridNode.js:536: * @param
{?NetworkAgent.ResourcePriority} priority
@return

https://codereview.chromium.org/1323143005/diff/1/Source/devtools/front_end/n...
Source/devtools/front_end/network/NetworkDataGridNode.js:544:
labelMap[NetworkAgent.ResourcePriority.VeryLow] =
WebInspector.UIString("VeryLow");
Ain't the indices of string type?

https://codereview.chromium.org/1323143005/diff/1/Source/devtools/front_end/n...
Source/devtools/front_end/network/NetworkDataGridNode.js:548:
labelMap[NetworkAgent.ResourcePriority.VeryHigh] =
WebInspector.UIString("VeryHigh");
May be add a space: Very High?

https://codereview.chromium.org/1323143005/diff/1/Source/devtools/front_end/n...
Source/devtools/front_end/network/NetworkDataGridNode.js:684: return aScore -
bScore || a._request.indentityCompare(b._request)
; missing

[paulirish, 2015-09-02 21:01:28]

paulirish@chromium.org changed reviewers:
+ paulirish@chromium.org

[paulirish, 2015-09-02 21:01:28]

https://codereview.chromium.org/1323143005/diff/1/Source/devtools/front_end/n...
File Source/devtools/front_end/network/NetworkDataGridNode.js (right):

https://codereview.chromium.org/1323143005/diff/1/Source/devtools/front_end/n...
Source/devtools/front_end/network/NetworkDataGridNode.js:548:
labelMap[NetworkAgent.ResourcePriority.VeryHigh] =
WebInspector.UIString("VeryHigh");
On 2015/09/02 at 20:38:53, alph wrote:
> May be add a space: Very High?

Yes please. "Very Low", "Very High"

[caseq, 2015-09-02 21:18:45]

On 2015/09/02 20:38:53, alph wrote:
> lgtm
> 
>
https://codereview.chromium.org/1323143005/diff/1/Source/devtools/front_end/n...
> File Source/devtools/front_end/network/NetworkDataGridNode.js (right):
> 
>
https://codereview.chromium.org/1323143005/diff/1/Source/devtools/front_end/n...
> Source/devtools/front_end/network/NetworkDataGridNode.js:536: * @param
> {?NetworkAgent.ResourcePriority} priority
> @return

Done.

>
https://codereview.chromium.org/1323143005/diff/1/Source/devtools/front_end/n...
> Source/devtools/front_end/network/NetworkDataGridNode.js:544:
> labelMap[NetworkAgent.ResourcePriority.VeryLow] =
> WebInspector.UIString("VeryLow");
> Ain't the indices of string type?

Thanks for spotting, but changed this to Map() anyway.

>
https://codereview.chromium.org/1323143005/diff/1/Source/devtools/front_end/n...
> Source/devtools/front_end/network/NetworkDataGridNode.js:548:
> labelMap[NetworkAgent.ResourcePriority.VeryHigh] =
> WebInspector.UIString("VeryHigh");
> May be add a space: Very High?

As discussed offline, renamed Very High/Very Low to Highest/Lowest for better
readability.

>
https://codereview.chromium.org/1323143005/diff/1/Source/devtools/front_end/n...
> Source/devtools/front_end/network/NetworkDataGridNode.js:684: return aScore -
> bScore || a._request.indentityCompare(b._request)
> ; missing

Fixed.

[caseq, 2015-09-02 21:18:49]

The CQ bit was checked by caseq@chromium.org

[caseq, 2015-09-02 21:18:49]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/1323143005/#ps20001
(title: "review comments addressed")

[commit-bot: I haz the power, 2015-09-02 21:19:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323143005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323143005/20001

[alph, 2015-09-02 21:21:15]

https://codereview.chromium.org/1323143005/diff/20001/Source/devtools/front_e...
File Source/devtools/front_end/network/NetworkDataGridNode.js (right):

https://codereview.chromium.org/1323143005/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/network/NetworkDataGridNode.js:536: * @param
{?NetworkAgent.ResourcePriority} priority
so, what about @return?

[commit-bot: I haz the power, 2015-09-02 22:17:54]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201673