Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1878)

Unified Diff: Source/devtools/front_end/network/NetworkLogView.js

Issue 1323143005: DevTools: expose initial request priority in the Network panel UI (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: review comments addressed Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/network/NetworkLogView.js
diff --git a/Source/devtools/front_end/network/NetworkLogView.js b/Source/devtools/front_end/network/NetworkLogView.js
index 43eac1d795cb1ae347af5a2a8743f417cde09c43..bdc3e17eb47d7df1b57cebfd140c36a62b99c3b5 100644
--- a/Source/devtools/front_end/network/NetworkLogView.js
+++ b/Source/devtools/front_end/network/NetworkLogView.js
@@ -116,7 +116,7 @@ WebInspector.NetworkLogView._isMatchingSearchQuerySymbol = Symbol("isMatchingSea
WebInspector.NetworkLogView.HTTPSchemas = {"http": true, "https": true, "ws": true, "wss": true};
WebInspector.NetworkLogView._responseHeaderColumns = ["Cache-Control", "Connection", "Content-Encoding", "Content-Length", "ETag", "Keep-Alive", "Last-Modified", "Server", "Vary"];
WebInspector.NetworkLogView._defaultColumnsVisibility = {
- method: false, status: true, protocol: false, scheme: false, domain: false, remoteAddress: false, type: true, initiator: true, cookies: false, setCookies: false, size: true, time: true, connectionId: false,
+ method: false, status: true, protocol: false, scheme: false, domain: false, remoteAddress: false, type: true, initiator: true, cookies: false, setCookies: false, size: true, time: true, priority: false, connectionId: false,
"Cache-Control": false, "Connection": false, "Content-Encoding": false, "Content-Length": false, "ETag": false, "Keep-Alive": false, "Last-Modified": false, "Server": false, "Vary": false
};
WebInspector.NetworkLogView._defaultRefreshDelay = 200;
@@ -163,6 +163,7 @@ WebInspector.NetworkLogView._columnTitles = {
"size": WebInspector.UIString("Size"),
"time": WebInspector.UIString("Time"),
"connectionId": WebInspector.UIString("Connection Id"),
+ "priority": WebInspector.UIString("Priority"),
"timeline": WebInspector.UIString("Timeline"),
// Response header columns
@@ -428,6 +429,12 @@ WebInspector.NetworkLogView.prototype = {
});
columns.push({
+ id: "priority",
+ title: WebInspector.NetworkLogView._columnTitles["priority"],
+ weight: 6
+ });
+
+ columns.push({
id: "connectionId",
title: WebInspector.NetworkLogView._columnTitles["connectionId"],
weight: 6
@@ -614,6 +621,7 @@ WebInspector.NetworkLogView.prototype = {
this._sortingFunctions.size = WebInspector.NetworkDataGridNode.SizeComparator;
this._sortingFunctions.time = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "duration", false);
this._sortingFunctions.connectionId = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "connectionId", false);
+ this._sortingFunctions.priority = WebInspector.NetworkDataGridNode.InitialPriorityComparator;
this._sortingFunctions.timeline = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "startTime", false);
this._sortingFunctions.startTime = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "startTime", false);
this._sortingFunctions.endTime = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "endTime", false);

Powered by Google App Engine
This is Rietveld 408576698