Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: media/base/video_capture_types_unittest.cc

Issue 1323093006: Change the media::PowerLineFrequency from an enum class to a proper class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/base/video_capture_types.cc ('K') | « media/base/video_capture_types.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_capture_types_unittest.cc
diff --git a/media/base/video_capture_types_unittest.cc b/media/base/video_capture_types_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c4def9cac863b3abf8ec2fd1f481d59888f243a0
--- /dev/null
+++ b/media/base/video_capture_types_unittest.cc
@@ -0,0 +1,22 @@
+#include "video_capture_types.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace media {
+ TEST(PowerLineFrequency, testCompare) {
+ PowerLineFrequency p50_a(PowerLineFrequency::FREQUENCY_50HZ);
ajose 2015/09/10 17:24:55 Consider using more descriptive variable names.
suvanjanmukherjee 2015/09/13 15:33:46 Using only one variable in the new test. Simple se
+ PowerLineFrequency p50_b = PowerLineFrequency::FREQUENCY_50HZ;
+ EXPECT_EQ(p50_a, p50_b);
+ EXPECT_EQ(p50_a, 50);
+ }
+
+ TEST(PowerLineFrequency, testSwitchCase) {
+ PowerLineFrequency p50 = PowerLineFrequency::FREQUENCY_50HZ;
+ bool result = false;
+ switch(p50) {
+ case PowerLineFrequency::FREQUENCY_50HZ: result = true; break;
wolenetz 2015/09/09 19:39:15 nit: make the case and default code blocks multi-l
suvanjanmukherjee 2015/09/13 15:33:46 No longer using a switch case here
+ default: result = false; break;
+ }
+
+ EXPECT_TRUE(result);
+ }
+}
« media/base/video_capture_types.cc ('K') | « media/base/video_capture_types.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698