Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: media/base/video_capture_types.cc

Issue 1323093006: Change the media::PowerLineFrequency from an enum class to a proper class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/video_capture_types.cc
diff --git a/media/base/video_capture_types.cc b/media/base/video_capture_types.cc
index 0bc6ae639511625fe34fa214aacb01fd65d860d9..f549f84234c665c6d856e68f27ae7bfeb71d14de 100644
--- a/media/base/video_capture_types.cc
+++ b/media/base/video_capture_types.cc
@@ -11,6 +11,35 @@
namespace media {
+ void PowerLineFrequency::check(int freq)
wolenetz 2015/09/09 19:39:15 nit: remember to follow the updated declaration or
suvanjanmukherjee 2015/09/13 15:33:46 Done.
+ {
ajose 2015/09/10 17:24:55 Move open curly brace to the end of the same line
suvanjanmukherjee 2015/09/13 15:33:46 Done.
+ DCHECK(freq >= FREQUENCY_DEFAULT && freq <= FREQUENCY_MAX);
+ }
+
+ PowerLineFrequency::PowerLineFrequency(int freq)
+ {
+ check(freq);
+ freq_ = freq;
wolenetz 2015/09/09 19:39:15 nit: s/ / /
suvanjanmukherjee 2015/09/13 15:33:46 Done.
+ }
+
+ PowerLineFrequency& PowerLineFrequency::operator= (int freq)
+ {
+ check(freq);
+ freq_ = freq;
+ return *this;
+ }
+
+ PowerLineFrequency& PowerLineFrequency::operator= (
+ const PowerLineFrequency& rhs)
+ {
+ freq_ = rhs.freq_;
+ return *this;
+ }
+
+ PowerLineFrequency::operator int() const {
+ return freq_;
+ }
+
// This list is ordered by precedence of use.
static VideoPixelFormat const kSupportedCapturePixelFormats[] = {
PIXEL_FORMAT_I420,

Powered by Google App Engine
This is Rietveld 408576698