LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html - Issue 1323053004: [CSS Grid Layout] Flex tracks sizing alg must handle 0fr values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html

Issue 1323053004: [CSS Grid Layout] Flex tracks sizing alg must handle 0fr values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Function normalizedFlexFraction moved Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/flex-content-resolution-columns.html » ('j') | LayoutTests/fast/css-grid-layout/flex-content-resolution-columns.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html

diff --git a/LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html b/LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html

index 62ac07b962c1699b350991bb081bca0e2a4c3f59..ecba1a5e5145a39ee0672ab66e307db462163026 100644

--- a/LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html

+++ b/LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html

@@ -130,7 +130,7 @@

<div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50" data-expected-height="40">XXXXX XXXXX XXXXX XXXXX</div>

- <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="50" data-expected-height="160"></div>

+ <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="50" data-expected-height="80"></div>

svillar 2015/09/08 13:27:07 Shouldn't it be x4 the one in first row?

jfernandez 2015/09/09 09:23:22 Actually not. Specs want fraction units to be norm

</div>