LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html - Issue 1323053004: [CSS Grid Layout] Flex tracks sizing alg must handle 0fr values

Side by Side Diff: LayoutTests/fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html

Issue 1323053004: [CSS Grid Layout] Flex tracks sizing alg must handle 0fr values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Function normalizedFlexFraction moved Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/flex-content-resolution-columns.html » ('j') | LayoutTests/fast/css-grid-layout/flex-content-resolution-columns.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <link href="resources/grid.css" rel="stylesheet">	3 <link href="resources/grid.css" rel="stylesheet">

4 <style>	4 <style>

5 .gridMaxMaxContent {	5 .gridMaxMaxContent {

6 grid-template-columns: 50px;	6 grid-template-columns: 50px;

7 grid-template-rows: minmax(10px, max-content) minmax(10px, 1fr);	7 grid-template-rows: minmax(10px, max-content) minmax(10px, 1fr);

8 }	8 }

9	9

10 .gridMinMinContent {	10 .gridMinMinContent {

(...skipping 112 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
123 <div style="width: 10px; height: 60px;">	123 <div style="width: 10px; height: 60px;">

124 <div class="grid gridWithIntrinsicSizeBiggerThanFlex" style="height: 100%">	124 <div class="grid gridWithIntrinsicSizeBiggerThanFlex" style="height: 100%">

125 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="40">XXXXX XXXXX XXXXX XXXXX</div>	125 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="40">XXXXX XXXXX XXXXX XXXXX</div>

126 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="20"></div>	126 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="20"></div>

127 </div>	127 </div>

128 </div>	128 </div>

129	129

130 <div style="width: 10px; height: 60px;">	130 <div style="width: 10px; height: 60px;">

131 <div class="grid gridWithIntrinsicSizeBiggerThanFlex">	131 <div class="grid gridWithIntrinsicSizeBiggerThanFlex">

132 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="40">XXXXX XXXXX XXXXX XXXXX</div>	132 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="40">XXXXX XXXXX XXXXX XXXXX</div>

133 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="160"></div>	133 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="80"></div>
	svillar 2015/09/08 13:27:07 Shouldn't it be x4 the one in first row? Shouldn't it be x4 the one in first row? jfernandez 2015/09/09 09:23:22 Actually not. Specs want fraction units to be norm Show quoted text On 2015/09/08 13:27:07, svillar wrote: > Shouldn't it be x4 the one in first row? Actually not. Specs want fraction units to be normalized so they don't cause exponential grow of tracks with values greater than 1. However, I agree with you this deserve a comment in the test because it's really confusing.
134 </div>	134 </div>

135 </div>	135 </div>

136	136

137 <div style="width: 10px; height: 60px;">	137 <div style="width: 10px; height: 60px;">

138 <div class="grid gridShrinkBelowItemsIntrinsicSize" style="height: 100%">	138 <div class="grid gridShrinkBelowItemsIntrinsicSize" style="height: 100%">

139 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="20">XXXXX XXXXX XXXXX XXXXX XXXXX</div>	139 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="20">XXXXX XXXXX XXXXX XXXXX XXXXX</div>

140 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="40">XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX</div>	140 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="40">XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX</div>

141 </div>	141 </div>

142 </div>	142 </div>

143	143

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
199 <div class="grid gridWithNonFlexingItems">	199 <div class="grid gridWithNonFlexingItems">

200 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="40"></div>	200 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50 " data-expected-height="40"></div>

201 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="40">XXXXX XXXXX XXXXX XXXXX</div>	201 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="5 0" data-expected-height="40">XXXXX XXXXX XXXXX XXXXX</div>

202 <div class="sizedToGridArea thirdRowFirstColumn" data-expected-width="50 " data-expected-height="60">XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX</div>	202 <div class="sizedToGridArea thirdRowFirstColumn" data-expected-width="50 " data-expected-height="60">XXXXX XXXXX XXXXX XXXXX XXXXX XXXXX</div>

203 <div class="sizedToGridArea fourthRowFirstColumn" data-expected-width="5 0" data-expected-height="80"></div>	203 <div class="sizedToGridArea fourthRowFirstColumn" data-expected-width="5 0" data-expected-height="80"></div>

204 </div>	204 </div>

205 </div>	205 </div>

206	206

207 </body>	207 </body>

208 </html>	208 </html>

OLD	NEW