| Index: build/config/sanitizers/sanitizers.gni
|
| diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni
|
| index 6f7aebc5ab78e55af40cf2963b22f2e565b8457e..d5374e1a0ffb83f6b019d14e05f0f65c910da7b7 100644
|
| --- a/build/config/sanitizers/sanitizers.gni
|
| +++ b/build/config/sanitizers/sanitizers.gni
|
| @@ -25,15 +25,17 @@ declare_args() {
|
| }
|
|
|
| # MSan only links Chrome properly in release builds (brettw -- 9/1/2015). The
|
| -# same is possibly true for the other sanitizers. But regardless of whether it
|
| -# links, one would normally never run a sanitizer in debug mode. Running in
|
| -# debug mode probably indicates you forgot to set the "is_debug = false" flag
|
| -# in the build args.
|
| +# same is possibly true for the other non-ASan sanitizers. But regardless of
|
| +# whether it links, one would normally never run a sanitizer in debug mode.
|
| +# Running in debug mode probably indicates you forgot to set the "is_debug =
|
| +# false" flag in the build args. ASan seems to run fine in debug mode.
|
| #
|
| # If you find a use-case where you want to compile a sanitizer in debug mode
|
| -# and have verified it works, you can remove it from this condition. But please
|
| -# balance how common your use-case is versus how easy it is to forget to set
|
| -# the release flag, have an unpleasant time trying to use the sanitizer, and
|
| -# have to rebuild. For one-off builds, just comment this out locally.
|
| -assert(!is_debug || !(is_msan || is_asan || is_lsan || is_tsan),
|
| +# and have verified it works, ask brettw and we can consider removing it from
|
| +# this condition. We may also be able to find another way to enable your case
|
| +# without having people accidentally get broken builds by compiling an
|
| +# unsupported or unadvisable configurations.
|
| +#
|
| +# For one-off testing, just comment this assertion out.
|
| +assert(!is_debug || !(is_msan || is_lsan || is_tsan),
|
| "Sanitizers should generally be used in release (set is_debug=false).")
|
|
|