Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: build/config/sanitizers/sanitizers.gni

Issue 1322973003: Don't assert for debug asan builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Use libc++ (buildtools/third_party/libc++ and 6 # Use libc++ (buildtools/third_party/libc++ and
7 # buildtools/third_party/libc++abi) instead of stdlibc++ as standard library. 7 # buildtools/third_party/libc++abi) instead of stdlibc++ as standard library.
8 # This is intended to be used for instrumented builds. 8 # This is intended to be used for instrumented builds.
9 use_custom_libcxx = (is_asan && is_linux) || is_tsan || is_msan 9 use_custom_libcxx = (is_asan && is_linux) || is_tsan || is_msan
10 10
11 # Track where uninitialized memory originates from. From fastest to slowest: 11 # Track where uninitialized memory originates from. From fastest to slowest:
12 # 0 - no tracking, 1 - track only the initial allocation site, 2 - track the 12 # 0 - no tracking, 1 - track only the initial allocation site, 2 - track the
13 # chain of stores leading from allocation site to use site. 13 # chain of stores leading from allocation site to use site.
14 msan_track_origins = 2 14 msan_track_origins = 2
15 15
16 # Use dynamic libraries instrumented by one of the sanitizers instead of the 16 # Use dynamic libraries instrumented by one of the sanitizers instead of the
17 # standard system libraries. Set this flag to download prebuilt binaries from 17 # standard system libraries. Set this flag to download prebuilt binaries from
18 # GCS. 18 # GCS.
19 use_prebuilt_instrumented_libraries = false 19 use_prebuilt_instrumented_libraries = false
20 20
21 # Enable building with SyzyAsan which can find certain types of memory 21 # Enable building with SyzyAsan which can find certain types of memory
22 # errors. Only works on Windows. See 22 # errors. Only works on Windows. See
23 # https://code.google.com/p/sawbuck/wiki/SyzyASanHowTo 23 # https://code.google.com/p/sawbuck/wiki/SyzyASanHowTo
24 is_syzyasan = false 24 is_syzyasan = false
25 } 25 }
26 26
27 # MSan only links Chrome properly in release builds (brettw -- 9/1/2015). The 27 # MSan only links Chrome properly in release builds (brettw -- 9/1/2015). The
28 # same is possibly true for the other sanitizers. But regardless of whether it 28 # same is possibly true for the other non-ASan sanitizers. But regardless of
29 # links, one would normally never run a sanitizer in debug mode. Running in 29 # whether it links, one would normally never run a sanitizer in debug mode.
30 # debug mode probably indicates you forgot to set the "is_debug = false" flag 30 # Running in debug mode probably indicates you forgot to set the "is_debug =
31 # in the build args. 31 # false" flag in the build args. ASan seems to run fine in debug mode.
32 # 32 #
33 # If you find a use-case where you want to compile a sanitizer in debug mode 33 # If you find a use-case where you want to compile a sanitizer in debug mode
34 # and have verified it works, you can remove it from this condition. But please 34 # and have verified it works, ask brettw and we can consider removing it from
35 # balance how common your use-case is versus how easy it is to forget to set 35 # this condition. We may also be able to find another way to enable your case
36 # the release flag, have an unpleasant time trying to use the sanitizer, and 36 # without having people accidentally get broken builds by compiling an
37 # have to rebuild. For one-off builds, just comment this out locally. 37 # unsupported or unadvisable configurations.
38 assert(!is_debug || !(is_msan || is_asan || is_lsan || is_tsan), 38 #
39 # For one-off testing, just comment this assertion out.
40 assert(!is_debug || !(is_msan || is_lsan || is_tsan),
39 "Sanitizers should generally be used in release (set is_debug=false).") 41 "Sanitizers should generally be used in release (set is_debug=false).")
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698