Don't assert for debug asan builds.

Don't assert for debug asan builds.

I verified that Chrome seems to run decently well in this configuration.

Committed: https://crrev.com/b7b621a4fd840789beab4623879026a59014b9f2
Cr-Commit-Position: refs/heads/master@{#346980}

[brettw, 2015-09-02 17:21:34]

brettw@chromium.org changed reviewers:
+ sky@chromium.org

[brettw, 2015-09-02 17:21:39]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-02 17:22:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322973003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322973003/1

[sky, 2015-09-02 17:22:58]

LGTM

[sky, 2015-09-02 17:23:40]

While I think this looks good, I worry that this check is too heavy handed.
Other build targets may run perfectly well in any of these configs. Seems like
the assert should only apply to chrome.

[brettw, 2015-09-02 17:32:49]

On 2015/09/02 17:23:40, sky wrote:
> While I think this looks good, I worry that this check is too heavy handed.
> Other build targets may run perfectly well in any of these configs. Seems like
> the assert should only apply to chrome.

We can put it in chrome/BUILD.gn, but I'm not sure how many people this actually
helps. Most developers are working in a Chrome checkout, even if they're working
on some other component. I presume somebody will complain to me if they run into
this.

[sky, 2015-09-02 17:38:28]

I agree most developers are working in the chrome checkout, but it
seems entirely possible that someone may want to use *san to debug
something in base_unittests or any other random target.

  -Scott

On Wed, Sep 2, 2015 at 10:32 AM,  <brettw@chromium.org> wrote:
> On 2015/09/02 17:23:40, sky wrote:
>>
>> While I think this looks good, I worry that this check is too heavy
>> handed.
>> Other build targets may run perfectly well in any of these configs. Seems
>> like
>> the assert should only apply to chrome.
>
>
> We can put it in chrome/BUILD.gn, but I'm not sure how many people this
> actually
> helps. Most developers are working in a Chrome checkout, even if they're
> working
> on some other component. I presume somebody will complain to me if they run
> into
> this.
>
> https://codereview.chromium.org/1322973003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-09-02 17:56:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-02 17:56:50]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-09-02 18:05:03]

I changed the comment a bit to request that people ask me about how to enable
what they want.

I'm unsure how much people actually use these sanitizers on their desktop so I'm
not really sure how we should approach the right solution without hearing from
users.

[brettw, 2015-09-02 18:05:07]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-09-02 18:05:07]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1322973003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-09-02 18:05:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1322973003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1322973003/20001

[commit-bot: I haz the power, 2015-09-02 18:44:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-02 18:44:51]

Patchset 2 (id:??) landed as
https://crrev.com/b7b621a4fd840789beab4623879026a59014b9f2
Cr-Commit-Position: refs/heads/master@{#346980}