Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1322843005: Remove obsolete functionality from the MacroAssemblers. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete functionality from the MacroAssemblers. This is uncontroversial the dead code removal part of https://codereview.chromium.org/1307943013, which was previously landed, but got reverted because of DOM breakage that requires more investigation. TBR=jkummerow@chromium.org Committed: https://crrev.com/64e3bad3677d01d70ddcedd541619216b973e90d Cr-Commit-Position: refs/heads/master@{#30577}

Patch Set 1 #

Patch Set 2 : Fix arm64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -120 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +2 lines, -22 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
Hey Jakob, Landing this independently of the ClassOf change. TBR'ed as you already liked the ...
5 years, 3 months ago (2015-09-03 18:49:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322843005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322843005/1
5 years, 3 months ago (2015-09-03 18:49:45 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/9333)
5 years, 3 months ago (2015-09-03 18:53:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322843005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322843005/20001
5 years, 3 months ago (2015-09-03 19:47:15 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-03 20:11:24 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/64e3bad3677d01d70ddcedd541619216b973e90d Cr-Commit-Position: refs/heads/master@{#30577}
5 years, 3 months ago (2015-09-03 20:11:40 UTC) #9
Jakob Kummerow
5 years, 3 months ago (2015-09-04 08:18:20 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698