Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1307943013: [es5] Class of object is "Function" if object has [[Call]]. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Jarin, Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es5] Class of object is "Function" if object has [[Call]]. The concept of class was mostly removed from ES6, but we still use the class of objects to distinguish object kinds in our builtins. So update this to be in sync with IsCallable (thereby getting rid of the previous instance type based tests for callable things completely). R=jarin@chromium.org, jkummerow@chromium.org Committed: https://crrev.com/af778389947f1b01fb036756ea3cb8ed8ab98452 Cr-Commit-Position: refs/heads/master@{#30566}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix arm64 typo. #

Patch Set 3 : Address Jakobs comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -440 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +11 lines, -23 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 1 chunk +11 lines, -17 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 1 chunk +0 lines, -26 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +11 lines, -18 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +11 lines, -17 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +30 lines, -38 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 2 chunks +11 lines, -17 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 1 chunk +10 lines, -16 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +30 lines, -37 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +9 lines, -22 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +2 lines, -22 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +10 lines, -20 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +10 lines, -20 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -9 lines 0 comments Download
M src/objects.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +10 lines, -22 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Benedikt Meurer
5 years, 3 months ago (2015-09-03 12:31:53 UTC) #1
Benedikt Meurer
Hey guys, This is preliminary cleanup for proper bound functions support (and also proper ES6 ...
5 years, 3 months ago (2015-09-03 12:33:49 UTC) #2
Jakob Kummerow
LGTM with nits. https://codereview.chromium.org/1307943013/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (left): https://codereview.chromium.org/1307943013/diff/1/src/arm/lithium-codegen-arm.cc#oldcode2643 src/arm/lithium-codegen-arm.cc:2643: __ b(gt, is_false); For the record: ...
5 years, 3 months ago (2015-09-03 13:19:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307943013/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307943013/40001
5 years, 3 months ago (2015-09-03 13:20:52 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-03 14:10:03 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/af778389947f1b01fb036756ea3cb8ed8ab98452 Cr-Commit-Position: refs/heads/master@{#30566}
5 years, 3 months ago (2015-09-03 14:10:20 UTC) #8
Michael Achenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1306303005/ by machenbach@chromium.org. ...
5 years, 3 months ago (2015-09-03 15:02:09 UTC) #9
Benedikt Meurer
5 years, 3 months ago (2015-09-03 18:33:04 UTC) #10
Message was sent while issue was closed.
On 2015/09/03 15:02:09, Michael Achenbach wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1306303005/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] Changes several layout test
expectations.
> Please fix upstream first if intended. E.g.:
>
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...
> 
> Several lines change from PASS to FAIL..

Hm, there's indeed some funky interplay with WebIDL/DOM. I guess that'll have to
wait for Adam or bindings people to take a look; seems like this is related to
ongoing @@toStringTag problems.

Powered by Google App Engine
This is Rietveld 408576698