Mojo: Make the shell's loader log URL fetch errors.

Mojo: Make the shell's loader log URL fetch errors.

This is to help debugging and make various failures less mysterious.

R=darin@chromium.org, abarth@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243976

[abarth-chromium, 2014-01-09 20:09:30]

This looks fine, but I'm not sure I should be reviewing Mojo code at this time. 
I'm mostly focused on Blink performance at the moment.  Perhaps I should remove
myself from the OWNERS file?

[darin (slow to review), 2014-01-09 20:57:19]

LGTM

https://codereview.chromium.org/132283003/diff/1/mojo/shell/loader.cc
File mojo/shell/loader.cc (right):

https://codereview.chromium.org/132283003/diff/1/mojo/shell/loader.cc#newcode31
mojo/shell/loader.cc:31: if (status.status() != net::URLRequestStatus::SUCCESS)
{
nit: You could also use |!status.is_success()| here. (That allows for status_ ==
IO_PENDING, but you don't have to worry about that case since it should never be
set at this point.)

[viettrungluu, 2014-01-09 21:02:50]

Thanks.

https://codereview.chromium.org/132283003/diff/1/mojo/shell/loader.cc
File mojo/shell/loader.cc (right):

https://codereview.chromium.org/132283003/diff/1/mojo/shell/loader.cc#newcode31
mojo/shell/loader.cc:31: if (status.status() != net::URLRequestStatus::SUCCESS)
{
On 2014/01/09 20:57:19, darin wrote:
> nit: You could also use |!status.is_success()| here. (That allows for status_
==
> IO_PENDING, but you don't have to worry about that case since it should never
be
> set at this point.)

Done.

[viettrungluu, 2014-01-09 21:30:16]

Committed patchset #2 manually as r243976 (presubmit successful).