Mojo: Make the shell's loader log URL fetch errors.

mojo/shell/loader.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/shell/loader.h"
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "mojo/shell/switches.h"
 #include "net/base/load_flags.h"
 #include "net/base/network_delegate.h"
+#include "net/url_request/url_fetcher.h"
+#include "net/url_request/url_request_status.h"
 
 namespace mojo {
 namespace shell {
 
 Loader::Delegate::~Delegate() {
 }
 
 Loader::Job::Job(const GURL& app_url, Delegate* delegate)
     : delegate_(delegate) {
   fetcher_.reset(net::URLFetcher::Create(app_url, net::URLFetcher::GET, this));
 }
 
 Loader::Job::~Job() {
 }
 
 void Loader::Job::OnURLFetchComplete(const net::URLFetcher* source) {
+  net::URLRequestStatus status = source->GetStatus();
+  if (status.status() != net::URLRequestStatus::SUCCESS) {

[darin (slow to review), 2014/01/09 20:57:19]

nit: You could also use |!status.is_success()| here. (That allows for status_ ==
IO_PENDING, but you don't have to worry about that case since it should never be
set at this point.)

[viettrungluu, 2014/01/09 21:02:50]

Done.

+    LOG(ERROR) << "URL fetch didn't succeed: status = " << status.status()
+               << ", error = " << status.error();
+  } else if (source->GetResponseCode() != 200) {
+    LOG(ERROR) << "HTTP response not OK: code = " << source->GetResponseCode();
+  }
+  // TODO: Do something else in the error cases?
+
   base::FilePath app_path;
   source->GetResponseAsFilePath(true, &app_path);
   delegate_->DidCompleteLoad(source->GetURL(), app_path);
 }
 
 Loader::Loader(base::SingleThreadTaskRunner* network_runner,
                base::SingleThreadTaskRunner* file_runner,
                base::MessageLoopProxy* cache_runner,
                scoped_ptr<net::NetworkDelegate> network_delegate,
                base::FilePath base_path)
@@ skipping 14 matching lines @@
   job->fetcher_->SetRequestContext(url_request_context_getter_.get());
   job->fetcher_->SaveResponseToTemporaryFile(file_runner_.get());
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableCache))
     job->fetcher_->SetLoadFlags(net::LOAD_DISABLE_CACHE);
   job->fetcher_->Start();
   return job.Pass();
 }
 
 }  // namespace shell
 }  // namespace mojo