Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1322773004: Revert of Provides multiple implementations of Android's SkBitmapRegionDecoder (Closed)

Created:
5 years, 3 months ago by msarett
Modified:
5 years, 3 months ago
Reviewers:
scroggo, rmistry, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Provides multiple implementations of Android's SkBitmapRegionDecoder (patchset #16 id:360001 of https://codereview.chromium.org/1288963002/ ) Reason for revert: Breaking Android bots Bad use of the utils folder Original issue's description: > Provides various implementations of Android's SkBitmapRegionDecoder. > > Implements testing in DM for these implementations. > > nanobench testing will follow after this. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/76f755e6d54a32f9887ad254ce59a3a62f28bde4 TBR=scroggo@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/8fd97eab1d9c17c662e08f6b3dbd7be49ec0a838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -756 lines) Patch
M dm/DM.cpp View 3 chunks +7 lines, -113 lines 0 comments Download
M dm/DMSrcSink.h View 2 chunks +0 lines, -29 lines 0 comments Download
M dm/DMSrcSink.cpp View 2 chunks +3 lines, -159 lines 0 comments Download
M gyp/utils.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/utils.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D src/utils/SkBitmapRegionCanvas.h View 1 chunk +0 lines, -43 lines 0 comments Download
D src/utils/SkBitmapRegionCanvas.cpp View 1 chunk +0 lines, -189 lines 0 comments Download
D src/utils/SkBitmapRegionDecoderInterface.h View 1 chunk +0 lines, -77 lines 0 comments Download
D src/utils/SkBitmapRegionDecoderInterface.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
D src/utils/SkBitmapRegionSampler.h View 1 chunk +0 lines, -41 lines 0 comments Download
D src/utils/SkBitmapRegionSampler.cpp View 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
msarett
Created Revert of Provides multiple implementations of Android's SkBitmapRegionDecoder
5 years, 3 months ago (2015-09-08 13:44:44 UTC) #1
scroggo
lgtm LGTM Ravi, it seems like lately we need to LGTM reverts and click the ...
5 years, 3 months ago (2015-09-08 13:59:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322773004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322773004/1
5 years, 3 months ago (2015-09-08 13:59:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/8fd97eab1d9c17c662e08f6b3dbd7be49ec0a838
5 years, 3 months ago (2015-09-08 13:59:53 UTC) #6
scroggo
On 2015/09/08 13:59:53, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
5 years, 3 months ago (2015-09-08 14:01:57 UTC) #7
rmistry
On 2015/09/08 14:01:57, scroggo wrote: > On 2015/09/08 13:59:53, commit-bot: I haz the power wrote: ...
5 years, 3 months ago (2015-09-08 18:56:50 UTC) #8
msarett
5 years, 3 months ago (2015-09-08 18:58:44 UTC) #9
Message was sent while issue was closed.
Sorry I should have replied earlier and clarified this.

I don't think there was an issue here.  I intentionally created the Revert
without landing it immediately.

Powered by Google App Engine
This is Rietveld 408576698