Issue 1322693004: Fix a -Wsign-compare error under GCC 4.9.2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1322693004: Fix a -Wsign-compare error under GCC 4.9.2. (Closed)

Created:
5 years, 3 months ago by paul.l...

Modified:
5 years, 3 months ago

Reviewers:
Benedikt Meurer, Jakob Kummerow, Michael Achenbach

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix a -Wsign-compare error under GCC 4.9.2. BUG= Committed: https://crrev.com/c772010486dc5b03774e8b250110ade7b3229402 Cr-Commit-Position: refs/heads/master@{#30603}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	test/unittests/atomic-utils-unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

paul.l...

If this looks OK, please commit it also, as I will be OOO on Monday. ...

5 years, 3 months ago (2015-09-05 01:03:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322693004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322693004/1

5 years, 3 months ago (2015-09-05 11:17:17 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-05 11:43:15 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c772010486dc5b03774e8b250110ade7b3229402
Cr-Commit-Position: refs/heads/master@{#30603}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages