Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1748)

Unified Diff: test/unittests/atomic-utils-unittest.cc

Issue 1322693004: Fix a -Wsign-compare error under GCC 4.9.2. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/atomic-utils-unittest.cc
diff --git a/test/unittests/atomic-utils-unittest.cc b/test/unittests/atomic-utils-unittest.cc
index 060973630179aca5174f2d34c9e9cf7131da2d8b..a0d8a6a5085326248f3030294557baf0246becc3 100644
--- a/test/unittests/atomic-utils-unittest.cc
+++ b/test/unittests/atomic-utils-unittest.cc
@@ -16,7 +16,7 @@ TEST(AtomicNumber, Constructor) {
AtomicNumber<size_t> zero_size_t;
AtomicNumber<intptr_t> zero_intptr_t;
EXPECT_EQ(0, zero_int.Value());
- EXPECT_EQ(0, zero_size_t.Value());
+ EXPECT_EQ(0U, zero_size_t.Value());
EXPECT_EQ(0, zero_intptr_t.Value());
}
@@ -27,7 +27,7 @@ TEST(AtomicNumber, Value) {
AtomicNumber<int> b(-1);
EXPECT_EQ(-1, b.Value());
AtomicNumber<size_t> c(1);
- EXPECT_EQ(1, c.Value());
+ EXPECT_EQ(1U, c.Value());
AtomicNumber<size_t> d(static_cast<size_t>(-1));
EXPECT_EQ(std::numeric_limits<size_t>::max(), d.Value());
}
@@ -53,7 +53,7 @@ TEST(AtomicNumber, Increment) {
// Should work as decrement as well.
AtomicNumber<size_t> c(1);
c.Increment(-1);
- EXPECT_EQ(0, c.Value());
+ EXPECT_EQ(0U, c.Value());
c.Increment(-1);
EXPECT_EQ(std::numeric_limits<size_t>::max(), c.Value());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698