Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 1322533002: bindings: Supports to change the method location. (Closed)

Created:
5 years, 3 months ago by Yuki
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, vivekg, blink-reviews-bindings_chromium.org, vivekg_samsung
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Supports to change the method location among instance, prototype and interface. There should be no behavioral change. BUG=43394, 516274 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201910

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Total comments: 4

Patch Set 12 : Addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+493 lines, -571 lines) Patch
M Source/bindings/core/v8/V8DOMConfiguration.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/core/v8/V8DOMConfiguration.cpp View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +37 lines, -32 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 1 2 3 4 5 6 7 8 9 3 chunks +2 lines, -9 lines 0 comments Download
M Source/bindings/scripts/v8_utilities.py View 1 2 3 4 5 6 7 8 3 chunks +5 lines, -3 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 1 2 3 4 5 6 3 chunks +2 lines, -12 lines 0 comments Download
M Source/bindings/templates/conversions.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +15 lines, -0 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +11 lines, -9 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -3 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 2 3 4 5 6 1 chunk +7 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestException.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +51 lines, -87 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface3.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +12 lines, -22 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +10 lines, -10 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +269 lines, -291 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +8 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +20 lines, -28 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yuki
Finally passed the tests. Could you take a look at this CL?
5 years, 3 months ago (2015-09-08 08:17:15 UTC) #2
haraken
On 2015/09/08 08:17:15, Yuki wrote: > Finally passed the tests. This CL is just refactoring ...
5 years, 3 months ago (2015-09-08 08:37:11 UTC) #3
Yuki
Yes, this CL meant for a refactoring and will not change behaviors. The reason why ...
5 years, 3 months ago (2015-09-08 08:49:46 UTC) #4
haraken
LGTM https://codereview.chromium.org/1322533002/diff/200001/Source/bindings/core/v8/V8DOMConfiguration.cpp File Source/bindings/core/v8/V8DOMConfiguration.cpp (right): https://codereview.chromium.org/1322533002/diff/200001/Source/bindings/core/v8/V8DOMConfiguration.cpp#newcode186 Source/bindings/core/v8/V8DOMConfiguration.cpp:186: v8::Local<v8::FunctionTemplate> functionTemplate = v8::FunctionTemplate::New(isolate, callback, v8::Local<v8::Value>(), v8::Local<v8::Signature>(), method.length); ...
5 years, 3 months ago (2015-09-08 08:57:14 UTC) #5
Yuki
https://codereview.chromium.org/1322533002/diff/200001/Source/bindings/core/v8/V8DOMConfiguration.cpp File Source/bindings/core/v8/V8DOMConfiguration.cpp (right): https://codereview.chromium.org/1322533002/diff/200001/Source/bindings/core/v8/V8DOMConfiguration.cpp#newcode186 Source/bindings/core/v8/V8DOMConfiguration.cpp:186: v8::Local<v8::FunctionTemplate> functionTemplate = v8::FunctionTemplate::New(isolate, callback, v8::Local<v8::Value>(), v8::Local<v8::Signature>(), method.length); On ...
5 years, 3 months ago (2015-09-08 09:49:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322533002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322533002/220001
5 years, 3 months ago (2015-09-08 09:49:46 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 12:01:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #12 (id:220001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201910

Powered by Google App Engine
This is Rietveld 408576698