Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 1322533002: bindings: Supports to change the method location. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed review comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_utilities.py ('k') | Source/bindings/templates/conversions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/attributes.cpp
diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp
index 97037edcf23b831f2a15e77b435b7900ba67ecc4..42406ece7142468f972cb667dcf9c43beff24969 100644
--- a/Source/bindings/templates/attributes.cpp
+++ b/Source/bindings/templates/attributes.cpp
@@ -489,6 +489,7 @@ bool {{v8_class}}::PrivateScript::{{attribute.name}}AttributeSetter(LocalFrame*
{##############################################################################}
{% macro attribute_configuration(attribute) %}
+{% from 'conversions.cpp' import property_location %}
{% if attribute.constructor_type %}
{% set getter_callback =
'%sV8Internal::%sConstructorGetterCallback' % (cpp_class_or_partial, attribute.name)
@@ -527,17 +528,6 @@ bool {{v8_class}}::PrivateScript::{{attribute.name}}AttributeSetter(LocalFrame*
'V8DOMConfiguration::OnlyExposedToPrivateScript'
if attribute.only_exposed_to_private_script else
'V8DOMConfiguration::ExposedToAllScripts' %}
-{% set property_location_list = [] %}
-{% if attribute.on_instance %}
-{% set property_location_list = property_location_list + ['V8DOMConfiguration::OnInstance'] %}
-{% endif %}
-{% if attribute.on_prototype %}
-{% set property_location_list = property_location_list + ['V8DOMConfiguration::OnPrototype'] %}
-{% endif %}
-{% if attribute.on_interface %}
-{% set property_location_list = property_location_list + ['V8DOMConfiguration::OnInterface'] %}
-{% endif %}
-{% set property_location = property_location_list | join(' | ') %}
{% set holder_check = 'V8DOMConfiguration::DoNotCheckHolder'
if attribute.is_lenient_this else 'V8DOMConfiguration::CheckHolder' %}
{% set attribute_configuration_list = [
@@ -550,7 +540,7 @@ bool {{v8_class}}::PrivateScript::{{attribute.name}}AttributeSetter(LocalFrame*
access_control,
property_attribute,
only_exposed_to_private_script,
- property_location,
+ property_location(attribute),
holder_check,
] %}
{{'{'}}{{attribute_configuration_list | join(', ')}}{{'}'}}
« no previous file with comments | « Source/bindings/scripts/v8_utilities.py ('k') | Source/bindings/templates/conversions.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698