Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1322343002: Don't use evdev except for target (Closed)

Created:
5 years, 3 months ago by Peter Mayo
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gtk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use evdev except for target libevdev-cros is not needed for the host tooling, and is not availale for the host in a chroot chromeos building environment. BUG=527996 Committed: https://crrev.com/97739b5fcf32a746c38d8142bff56d0072953dbf Cr-Commit-Position: refs/heads/master@{#347531}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : refactor #

Patch Set 5 : rebase #

Patch Set 6 : sync&rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M build/config/linux/BUILD.gn View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
M build/config/ui.gni View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M ui/events/ozone/BUILD.gn View 1 2 3 5 chunks +17 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (5 generated)
Peter Mayo
This is a small change, but I don't know why this functionality is buried so ...
5 years, 3 months ago (2015-09-03 20:46:20 UTC) #2
Dirk Pranke
Can you just do the refactoring and move the evdev logic out of //build/config/linux and ...
5 years, 3 months ago (2015-09-03 21:28:24 UTC) #3
Peter Mayo
rebase
5 years, 3 months ago (2015-09-03 22:15:14 UTC) #4
Peter Mayo
rebase
5 years, 3 months ago (2015-09-03 22:18:39 UTC) #5
Peter Mayo
rebase
5 years, 3 months ago (2015-09-04 02:02:30 UTC) #6
Peter Mayo
+kpschoedel@ for OWNERS
5 years, 3 months ago (2015-09-04 02:07:55 UTC) #8
kpschoedel
Handing over to spang because my build-fu is weak.
5 years, 3 months ago (2015-09-04 14:29:11 UTC) #10
spang
lgtm
5 years, 3 months ago (2015-09-04 16:05:35 UTC) #11
Dirk Pranke
lgtm, thanks for the cleanup!
5 years, 3 months ago (2015-09-04 18:39:31 UTC) #12
Peter Mayo
rebase
5 years, 3 months ago (2015-09-04 19:23:39 UTC) #13
Peter Mayo
sync&rebase
5 years, 3 months ago (2015-09-04 19:39:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322343002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322343002/100001
5 years, 3 months ago (2015-09-04 23:06:04 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-09-04 23:38:06 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 23:38:49 UTC) #19
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/97739b5fcf32a746c38d8142bff56d0072953dbf
Cr-Commit-Position: refs/heads/master@{#347531}

Powered by Google App Engine
This is Rietveld 408576698