Gate gtk on chromeos.

Gate gtk on chromeos.

We shouldn't use GTK in even the chromeos testing environment.
It breaks to even reference it in the chroot building env, since
the packages are not available.

BUG=527996
TEST=set gn args, gn gen

Committed: https://crrev.com/0d2ee9b94b2973ab266f663dc3a535d2d7ab9509
Cr-Commit-Position: refs/heads/master@{#347519}

[Peter Mayo, 2015-09-03 20:43:57]

petermayo@chromium.org changed reviewers:
+ dpranke@chromium.org

[Peter Mayo, 2015-09-03 21:22:48]

fetch/rebase

[Peter Mayo, 2015-09-03 21:23:43]

petermayo@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Peter Mayo, 2015-09-03 21:23:44]

+ jamiewalch - OWNERS

rebased.  gtk2.

[Dirk Pranke, 2015-09-03 21:25:05]

https://codereview.chromium.org/1319843004/diff/20001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1319843004/diff/20001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:455: if (is_linux && !is_chromeos) {
this might be clearer as 'is_desktop_linux', since I think that's really the
concept we're trying to gate on?

[Peter Mayo, 2015-09-03 21:56:24]

https://codereview.chromium.org/1319843004/diff/20001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1319843004/diff/20001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:84: if (is_linux && !is_chromeos) {
What about pam? is it more desktop, or more !chromeos ?

https://codereview.chromium.org/1319843004/diff/20001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:93: if (!is_chromeos) {
Should this condition match the use of gtk below too?

[I think so]

https://codereview.chromium.org/1319843004/diff/20001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:455: if (is_linux && !is_chromeos) {
On 2015/09/03 21:25:05, Dirk Pranke wrote:
> this might be clearer as 'is_desktop_linux', since I think that's really the
> concept we're trying to gate on?

I ...

selected_template=mal_no_objections

[Dirk Pranke, 2015-09-03 21:58:09]

https://codereview.chromium.org/1319843004/diff/20001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1319843004/diff/20001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:84: if (is_linux && !is_chromeos) {
On 2015/09/03 21:56:24, Peter Mayo wrote:
> What about pam? is it more desktop, or more !chromeos ?

I have no idea how pam is currently used in our builds :(.

https://codereview.chromium.org/1319843004/diff/20001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:93: if (!is_chromeos) {
On 2015/09/03 21:56:24, Peter Mayo wrote:
> Should this condition match the use of gtk below too?
> 
> [I think so]

Probably.

[Peter Mayo, 2015-09-03 22:12:39]

use is_desktop_linux to gate gtk usea

[Peter Mayo, 2015-09-03 22:13:33]

PTAL.

[Peter Mayo, 2015-09-03 22:18:12]

fix pam condition

[Dirk Pranke, 2015-09-03 22:19:38]

lgtm

[Peter Mayo, 2015-09-04 02:01:48]

rebase

[Jamie, 2015-09-04 18:21:40]

lgtm

https://codereview.chromium.org/1319843004/diff/60001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1319843004/diff/60001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:93: if (is_desktop_linux) {
Why this change? I like that it's consistent with the change below, but wanted
to check that there wasn't something more subtle going on here.

[Peter Mayo, 2015-09-04 18:29:17]

https://codereview.chromium.org/1319843004/diff/60001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1319843004/diff/60001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:93: if (is_desktop_linux) {
On 2015/09/04 18:21:40, Jamie wrote:
> Why this change? I like that it's consistent with the change below, but wanted
> to check that there wasn't something more subtle going on here.

Today the difference is in readability.  In the future defining what the
difference between "desktop" and "not chromeos" is we find things in between,
for example, other embedded distributions.  This shines a light on what the
technical implications of calling something "desktop" are.  e.g. shares versus
owns, uses gtk widgets, etc.

Contrast that with the choice for the pam library, which we expect whatever is
between chromeos and desktop to still want.

Again, the driver for changing this now is consistency.

[Peter Mayo, 2015-09-04 19:23:15]

rebase

[Peter Mayo, 2015-09-04 19:39:00]

sync&rebase

[Peter Mayo, 2015-09-04 22:11:15]

The CQ bit was checked by petermayo@chromium.org

[Peter Mayo, 2015-09-04 22:11:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1319843004/#ps120001
(title: "sync&rebase")

[commit-bot: I haz the power, 2015-09-04 22:11:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1319843004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1319843004/120001

[commit-bot: I haz the power, 2015-09-04 22:23:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 22:23:13]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peter Mayo, 2015-09-04 22:54:35]

The CQ bit was checked by petermayo@chromium.org

[commit-bot: I haz the power, 2015-09-04 22:54:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1319843004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1319843004/120001

[commit-bot: I haz the power, 2015-09-04 23:00:48]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-09-04 23:01:27]

Patchset 7 (id:??) landed as
https://crrev.com/0d2ee9b94b2973ab266f663dc3a535d2d7ab9509
Cr-Commit-Position: refs/heads/master@{#347519}