Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: src/a64/simulator-a64.cc

Issue 132233055: Consistenly use stderr for printing simulator and debug messages (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/a64/simulator-a64.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/a64/simulator-a64.cc
diff --git a/src/a64/simulator-a64.cc b/src/a64/simulator-a64.cc
index 34b5d7633f05b398069876d46be4fc0ed68dd0e5..e4af9235fa8eb0bd21bca1357af618ec8898dff8 100644
--- a/src/a64/simulator-a64.cc
+++ b/src/a64/simulator-a64.cc
@@ -945,15 +945,15 @@ void Simulator::PrintWrite(uint8_t* address,
// Visitors---------------------------------------------------------------------
void Simulator::VisitUnimplemented(Instruction* instr) {
- printf("Unimplemented instruction at 0x%p: 0x%08" PRIx32 "\n",
- reinterpret_cast<void*>(instr), instr->InstructionBits());
+ fprintf(stream_, "Unimplemented instruction at 0x%p: 0x%08" PRIx32 "\n",
+ reinterpret_cast<void*>(instr), instr->InstructionBits());
UNIMPLEMENTED();
}
void Simulator::VisitUnallocated(Instruction* instr) {
- printf("Unallocated instruction at 0x%p: 0x%08" PRIx32 "\n",
- reinterpret_cast<void*>(instr), instr->InstructionBits());
+ fprintf(stream_, "Unallocated instruction at 0x%p: 0x%08" PRIx32 "\n",
+ reinterpret_cast<void*>(instr), instr->InstructionBits());
UNIMPLEMENTED();
}
@@ -1238,11 +1238,13 @@ void Simulator::LoadStoreHelper(Instruction* instr,
uint64_t stack_limit = reinterpret_cast<uint64_t>(stack_limit_);
uint64_t stack_address = sp();
if ((access_address >= stack_limit) && (access_address < stack_address)) {
- printf("ACCESS BELOW STACK POINTER:\n");
- printf(" sp is here: 0x%016" PRIx64 "\n", stack_address);
- printf(" access was here: 0x%016" PRIx64 "\n", access_address);
- printf(" stack limit is here: 0x%016" PRIx64 "\n", stack_limit);
- printf("\n");
+ fprintf(stream_, "ACCESS BELOW STACK POINTER:\n");
+ fprintf(stream_, " sp is here: 0x%016" PRIx64 "\n",
+ stack_address);
+ fprintf(stream_, " access was here: 0x%016" PRIx64 "\n",
+ access_address);
+ fprintf(stream_, " stack limit is here: 0x%016" PRIx64 "\n", stack_limit);
+ fprintf(stream_, "\n");
ABORT();
}
@@ -3378,20 +3380,20 @@ void Simulator::VisitException(Instruction* instr) {
// Pass all of the relevant PCS registers onto printf. It doesn't
// matter if we pass too many as the extra ones won't be read.
int result;
- fputs(clr_printf, stdout);
+ fputs(clr_printf, stream_);
if (type == CPURegister::kRegister) {
- result = printf(format,
- xreg(1), xreg(2), xreg(3), xreg(4),
- xreg(5), xreg(6), xreg(7));
+ result = fprintf(stream_, format,
+ xreg(1), xreg(2), xreg(3), xreg(4),
+ xreg(5), xreg(6), xreg(7));
} else if (type == CPURegister::kFPRegister) {
- result = printf(format,
- dreg(0), dreg(1), dreg(2), dreg(3),
- dreg(4), dreg(5), dreg(6), dreg(7));
+ result = fprintf(stream_, format,
+ dreg(0), dreg(1), dreg(2), dreg(3),
+ dreg(4), dreg(5), dreg(6), dreg(7));
} else {
ASSERT(type == CPURegister::kNoRegister);
- result = printf("%s", format);
+ result = fprintf(stream_, "%s", format);
}
- fputs(clr_normal, stdout);
+ fputs(clr_normal, stream_);
set_xreg(0, result);
// TODO(jbramley): Consider clobbering all caller-saved registers here.
« no previous file with comments | « src/a64/simulator-a64.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698