Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 132233027: Revert some movq->movp changes under the _WIN64 macro for X64 (Closed)

Created:
6 years, 11 months ago by haitao.feng
Modified:
6 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Revert some movq->movp changes under the _WIN64 macro for X64 R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M src/x64/codegen-x64.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
Hi Toon, This is a follow-up of https://codereview.chromium.org/137443004 and https://codereview.chromium.org/105503006. I examined the movp usage ...
6 years, 11 months ago (2014-01-21 03:42:28 UTC) #1
Toon Verwaest
lgtm
6 years, 11 months ago (2014-01-23 09:44:07 UTC) #2
haitao.feng
6 years, 11 months ago (2014-01-24 01:59:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18803 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698