Issue 105503006: Replace movq with movp for X64 when the operand size is kPointerSize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 105503006: Replace movq with movp for X64 when the operand size is kPointerSize (Closed)

Created:
7 years ago by haitao.feng

Modified:
6 years, 11 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Replace movq with movp for X64 when the operand size is kPointerSize R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18675

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1051 lines, -1051 lines)			Patch
M	src/x64/builtins-x64.cc	View	1	46 chunks	+78 lines, -78 lines	0 comments	Download
M	src/x64/code-stubs-x64.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	126 chunks	+255 lines, -255 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	19 chunks	+29 lines, -29 lines	0 comments	Download
M	src/x64/debug-x64.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View	1	6 chunks	+13 lines, -13 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1	96 chunks	+176 lines, -176 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1	43 chunks	+56 lines, -56 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	68 chunks	+97 lines, -97 lines	0 comments	Download
M	src/x64/lithium-gap-resolver-x64.cc	View	1	4 chunks	+12 lines, -12 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1	129 chunks	+194 lines, -194 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.cc	View		24 chunks	+42 lines, -42 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	59 chunks	+90 lines, -90 lines	0 comments	Download

Total messages: 3 (0 generated)

haitao.feng

PTAL. I worked out this patch by modifying the python x32 generator to only replace ...

7 years ago (2013-12-05 06:58:46 UTC) #1

haitao.feng

6 years, 11 months ago (2014-01-20 05:00:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r18675 (presubmit successful).