tools/perf/metrics/v8_object_stats.py - Issue 132213002: [Telemetry]: Fix v8_object_stats metric to avoid having a '.' in trace names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/v8_object_stats.py

Issue 132213002: [Telemetry]: Fix v8_object_stats metric to avoid having a '.' in trace names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/metrics/v8_object_stats.py

diff --git a/tools/perf/metrics/v8_object_stats.py b/tools/perf/metrics/v8_object_stats.py

index ca28121270745d7f7d497c8cfe3e13f22218fea1..92b3daf113342e6ae5b752a6a09457efccce3741 100644

--- a/tools/perf/metrics/v8_object_stats.py

+++ b/tools/perf/metrics/v8_object_stats.py

@@ -212,4 +212,5 @@ class V8ObjectStatsMetric(Metric):

"""Add results for this page to the results object."""

assert self._results != None, 'Must call Stop() first'

for counter_name in self._results:

- results.Add(counter_name, 'kb', self._results[counter_name] / 1024.0)

+ display_name = counter_name.replace('.', '_')

+ results.Add(display_name, 'kb', self._results[counter_name] / 1024.0)

« no previous file with comments | « no previous file | no next file » | no next file with comments »