Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: tools/perf/metrics/v8_object_stats.py

Issue 132213002: [Telemetry]: Fix v8_object_stats metric to avoid having a '.' in trace names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import json 5 import json
6 import logging 6 import logging
7 7
8 from metrics import Metric 8 from metrics import Metric
9 9
10 _COUNTER_NAMES = [ 10 _COUNTER_NAMES = [
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 def Stop(self, page, tab): 205 def Stop(self, page, tab):
206 """Get the values in the stats table after the page is loaded.""" 206 """Get the values in the stats table after the page is loaded."""
207 self._results = V8ObjectStatsMetric.GetV8StatsTable(tab, self._counters) 207 self._results = V8ObjectStatsMetric.GetV8StatsTable(tab, self._counters)
208 if not self._results: 208 if not self._results:
209 logging.warning('No V8 object stats from website: ' + page.display_name) 209 logging.warning('No V8 object stats from website: ' + page.display_name)
210 210
211 def AddResults(self, tab, results): 211 def AddResults(self, tab, results):
212 """Add results for this page to the results object.""" 212 """Add results for this page to the results object."""
213 assert self._results != None, 'Must call Stop() first' 213 assert self._results != None, 'Must call Stop() first'
214 for counter_name in self._results: 214 for counter_name in self._results:
215 results.Add(counter_name, 'kb', self._results[counter_name] / 1024.0) 215 display_name = counter_name.replace('.', '_')
216 results.Add(display_name, 'kb', self._results[counter_name] / 1024.0)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698