Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1322123003: Add composite() method to InterpolationType interface (Closed)

Created:
5 years, 3 months ago by alancutter (OOO until 2018)
Modified:
5 years, 3 months ago
Reviewers:
dstockwell, shans
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add composite() method to InterpolationType interface This change refactors composition of InterpolationValues to be handled by the InterpolationType::composite() virtual method. This allows different InterpolationTypes to handle composition of their InterpolationValues in their own way e.g. lists of shadows may force underlying values to become repeated to a lowest common multiple. This introduces no change in behaviour. BUG=437696 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -53 lines) Patch
M Source/core/animation/InterpolableValue.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/animation/InterpolationType.h View 4 chunks +19 lines, -6 lines 0 comments Download
M Source/core/animation/InvalidatableStyleInterpolation.cpp View 2 chunks +1 line, -45 lines 0 comments Download
A Source/core/animation/UnderlyingValue.h View 1 chunk +59 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
alancutter (OOO until 2018)
5 years, 3 months ago (2015-09-09 05:32:54 UTC) #2
dstockwell
lgtm
5 years, 3 months ago (2015-09-14 00:25:42 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322123003/1
5 years, 3 months ago (2015-09-14 06:02:26 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/133232)
5 years, 3 months ago (2015-09-14 06:44:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322123003/1
5 years, 3 months ago (2015-09-16 07:53:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/41326)
5 years, 3 months ago (2015-09-16 08:04:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322123003/1
5 years, 3 months ago (2015-09-16 23:57:13 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 01:21:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202408

Powered by Google App Engine
This is Rietveld 408576698