Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1318143005: Add mutableComponent() interface to InterpolationValue (Closed)

Created:
5 years, 3 months ago by alancutter (OOO until 2018)
Modified:
5 years, 3 months ago
Reviewers:
dstockwell, shans
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add mutableComponent() interface to InterpolationValue This change is a simple refactor to make mutation of InterpolationValues clear in preparation of adding a composite() method to InterpolationType which will operate on UnderlyingValues. This also isolates the InterpolableValue + NonInterpolableValue pair as an InterpolationComponentValue for easier data transfer to be used by future static InterpolationType conversion methods. This introduces no change in behaviour. BUG=437696 Committed: https://crrev.com/1819b0342299d7b8054bc11aefb72e6d3768bb6d git-svn-id: svn://svn.chromium.org/blink/trunk@202176 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -41 lines) Patch
M Source/core/animation/InterpolationType.h View 2 chunks +7 lines, -1 line 0 comments Download
M Source/core/animation/InterpolationValue.h View 2 chunks +20 lines, -11 lines 2 comments Download
M Source/core/animation/InvalidatableStyleInterpolation.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/InvalidatableStyleInterpolation.cpp View 2 chunks +29 lines, -28 lines 0 comments Download
M Source/core/animation/PrimitiveInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
alancutter (OOO until 2018)
5 years, 3 months ago (2015-09-09 05:32:36 UTC) #2
dstockwell
lgtm https://codereview.chromium.org/1318143005/diff/1/Source/core/animation/InterpolationValue.h File Source/core/animation/InterpolationValue.h (right): https://codereview.chromium.org/1318143005/diff/1/Source/core/animation/InterpolationValue.h#newcode44 Source/core/animation/InterpolationValue.h:44: InterpolationComponentValue& mutableComponent() { return m_component; } The component ...
5 years, 3 months ago (2015-09-14 00:24:36 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/1318143005/diff/1/Source/core/animation/InterpolationValue.h File Source/core/animation/InterpolationValue.h (right): https://codereview.chromium.org/1318143005/diff/1/Source/core/animation/InterpolationValue.h#newcode44 Source/core/animation/InterpolationValue.h:44: InterpolationComponentValue& mutableComponent() { return m_component; } On 2015/09/14 at ...
5 years, 3 months ago (2015-09-14 00:37:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318143005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318143005/1
5 years, 3 months ago (2015-09-14 00:39:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202176
5 years, 3 months ago (2015-09-14 05:09:48 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:29:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1819b0342299d7b8054bc11aefb72e6d3768bb6d

Powered by Google App Engine
This is Rietveld 408576698