DescriptionVector ICs: The Oracle needs to report feedback for the object literals and the count operation.
The refactoring is because it's awkward and error-prone to deterimine which IC slot an
ObjectLiteralProperty uses for feedback. The fix is for each one to know it's own slot. In the
numbering pass, we allocate slots for the ObjectLiteral, then hand out those slots into the
properties.
It adds one word to the ObjectLiteralProperty expression - I'm investigating if thats a
problem.
This changes makes compiling the object literal cleaner across the three compilers. Also, the
slot allocation logic in ObjectLiteral::ComputeFeedbackRequirements() was refactoring to mimic
the style in full-codegen. This is useful since it must remain in sync with
FullCodegen::VisitObjectLiteral().
Committed: https://crrev.com/752b0308df72461bfeb644bf6dd8dd331fcdb722
Cr-Commit-Position: refs/heads/master@{#30686}
Patch Set 1 #Patch Set 2 : REBASE. #Patch Set 3 : ObjectLiteral refactorin. #
Total comments: 7
Patch Set 4 : Comments. #
Total comments: 8
Patch Set 5 : Comments and ports. #Patch Set 6 : Webkit test found a bug with renumbering. #Patch Set 7 : One more small fix. #Patch Set 8 : REBASE, turned off flag. #
Messages
Total messages: 12 (4 generated)
|