Issue 132183006: Revert 244050 "This is part 1 of implemeting phantom windows for..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132183006: Revert 244050 "This is part 1 of implemeting phantom windows for..." (Closed)

Created:
6 years, 11 months ago by dcheng

Modified:
6 years, 11 months ago

Reviewers:
pkotwicz

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 244050 "This is part 1 of implemeting phantom windows for..." This is causing PhantomWindowControllerTest.PhantomWindowShow to fail on the Win 8 Aura bots. > This is part 1 of implemeting phantom windows for the window controls when using --ash-enable-alternate-caption-button > > Other notable changes: > - Switched to using layer animations instead of gfx::SlideAnimation > - Renamed PhantomWindowController::phantom_widget_ and PhantomWindowController::phantom_widget_start_ to PhantomWindowController::phantom_widget_in_target_root_ and PhantomWindowController::phantom_widget_in_start_root_ respectively. > - Removed PhantomWindowController::Hide(). Hiding the phantom window can now only be done via destroying the PhantomWindowController > > BUG=328930 > TEST=PhantomWindowControllerTest.* > > Review URL: https://codereview.chromium.org/101773004 TBR=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244090

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+268 lines, -265 lines)			Patch
M	trunk/src/ash/ash.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/ash/wm/gestures/system_pinch_handler.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	trunk/src/ash/wm/gestures/system_pinch_handler.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	trunk/src/ash/wm/workspace/phantom_window_controller.h	View	4 chunks	+39 lines, -18 lines	0 comments	Download
M	trunk/src/ash/wm/workspace/phantom_window_controller.cc	View	6 chunks	+68 lines, -68 lines	0 comments	Download
D	trunk/src/ash/wm/workspace/phantom_window_controller_unittest.cc	View	1 chunk	+0 lines, -170 lines	0 comments	Download
M	trunk/src/ash/wm/workspace/workspace_window_resizer.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	trunk/src/ash/wm/workspace/workspace_window_resizer.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	trunk/src/ash/wm/workspace/workspace_window_resizer_unittest.cc	View	3 chunks	+143 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r244090.

Expand Messages | Collapse Messages