Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 132173006: Provide real GPUSupport to ash for Chrome (Closed)

Created:
6 years, 10 months ago by James Cook
Modified:
6 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Provide real GPUSupport to ash for Chrome A recent refactor to extract src/content dependencies from ash broke GPU feature detection for panel fitting on Chrome OS. In particular the OutputConfigurator was set up using a stub GPUSupport object. Fix injection of the GPUSupport object -- move its creation to the ash::ShellDelegate interface. BUG=chrome-os-partner:25204, chrome-os-partner:24868 TEST=existing ash_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248226

Patch Set 1 #

Patch Set 2 : fix win (gpu_support) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -65 lines) Patch
M ash/ash.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/content_support/gpu_support_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
D ash/content_support/inject.h View 1 chunk +0 lines, -16 lines 0 comments Download
D ash/content_support/inject.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M ash/gpu_support.h View 1 2 chunks +2 lines, -1 line 0 comments Download
A ash/gpu_support_stub.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A ash/gpu_support_stub.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M ash/shell.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell.cc View 3 chunks +3 lines, -23 lines 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/shell_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
James Cook
skuhne, PTAL - Basically I'm just moving creation of the GPUSupport object to the ShellDelegate ...
6 years, 10 months ago (2014-01-31 01:37:42 UTC) #1
marcheu
On 2014/01/31 01:37:42, James Cook wrote: > skuhne, PTAL - Basically I'm just moving creation ...
6 years, 10 months ago (2014-01-31 02:16:40 UTC) #2
Mr4D (OOO till 08-26)
lgtm
6 years, 10 months ago (2014-01-31 04:28:44 UTC) #3
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 10 months ago (2014-01-31 16:30:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/132173006/130001
6 years, 10 months ago (2014-01-31 16:30:33 UTC) #5
commit-bot: I haz the power
Change committed as 248226
6 years, 10 months ago (2014-01-31 18:20:43 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 18:20:44 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 18:20:47 UTC) #8
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698