Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Unified Diff: ash/shell.cc

Issue 132173006: Provide real GPUSupport to ash for Chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix win (gpu_support) Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shell.h ('k') | ash/shell/content_client/shell_browser_main_parts.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shell.cc
diff --git a/ash/shell.cc b/ash/shell.cc
index 4c298a4aa1ac37da7c658bbf30634c1d1dfe8aa4..5b7fb0cd25108f90484d22217ef639a0e825fea3 100644
--- a/ash/shell.cc
+++ b/ash/shell.cc
@@ -158,23 +158,6 @@ class AshVisibilityController : public views::corewm::VisibilityController {
DISALLOW_COPY_AND_ASSIGN(AshVisibilityController);
};
-class DefaultGPUSupportImpl : public GPUSupport {
- public:
- DefaultGPUSupportImpl() {}
- virtual ~DefaultGPUSupportImpl() {}
-
- private:
- // Overridden from GPUSupport:
- virtual bool IsPanelFittingDisabled() const OVERRIDE {
- return false;
- }
- virtual void DisableGpuWatchdog() OVERRIDE {}
- virtual void GetGpuProcessHandles(
- const GetGpuProcessHandlesCallback& callback) const OVERRIDE {}
-
- DISALLOW_COPY_AND_ASSIGN(DefaultGPUSupportImpl);
-};
-
} // namespace
// static
@@ -577,10 +560,6 @@ void Shell::DoInitialWorkspaceAnimation() {
DoInitialAnimation();
}
-void Shell::SetGPUSupport(scoped_ptr<GPUSupport> gpu_support) {
- gpu_support_ = gpu_support.Pass();
-}
-
////////////////////////////////////////////////////////////////////////////////
// Shell, private:
@@ -597,12 +576,13 @@ Shell::Shell(ShellDelegate* delegate)
cursor_manager_(scoped_ptr<views::corewm::NativeCursorManager>(
native_cursor_manager_)),
simulate_modal_window_open_for_testing_(false),
- is_touch_hud_projection_enabled_(false),
- gpu_support_(new DefaultGPUSupportImpl) {
+ is_touch_hud_projection_enabled_(false) {
DCHECK(delegate_.get());
+ gpu_support_.reset(delegate_->CreateGPUSupport());
display_manager_.reset(new internal::DisplayManager);
display_controller_.reset(new DisplayController);
#if defined(OS_CHROMEOS) && defined(USE_X11)
+ // TODO: Move this initialization into Shell::Init().
output_configurator_->Init(!gpu_support_->IsPanelFittingDisabled());
user_metrics_recorder_.reset(new UserMetricsRecorder);
« no previous file with comments | « ash/shell.h ('k') | ash/shell/content_client/shell_browser_main_parts.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698