Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1321653004: X87: Remove obsolete functionality from the MacroAssemblers. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Remove obsolete functionality from the MacroAssemblers. port 64e3bad3677d01d70ddcedd541619216b973e90d (r30577) original commit message: This is uncontroversial the dead code removal part of https://codereview.chromium.org/1307943013, which was previously landed, but got reverted because of DOM breakage that requires more investigation. BUG= Committed: https://crrev.com/0fce748dc62985298ad354f3e1af2446c376bc36 Cr-Commit-Position: refs/heads/master@{#30611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -34 lines) Patch
M src/x87/macro-assembler-x87.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 2 chunks +2 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-06 10:22:05 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-07 07:18:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321653004/1
5 years, 3 months ago (2015-09-07 07:18:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-07 08:14:43 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 08:14:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fce748dc62985298ad354f3e1af2446c376bc36
Cr-Commit-Position: refs/heads/master@{#30611}

Powered by Google App Engine
This is Rietveld 408576698