Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1321583002: IndexedDB: Make getAll() requests fail if result exceeds IPC limits (Closed)

Created:
5 years, 3 months ago by jsbell
Modified:
5 years, 3 months ago
Reviewers:
cmumford
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Make getAll() requests fail if result exceeds IPC limits The (experimental) IDBObjectStore/IDBIndex.getAll()/getAllKeys() methods can return an arbitrary number of results. When the resulting payload would exceed the IPC message, fail the request with an UnknownError per discussion w/ Moz. BUG=478949 R=cmumford@chromium.org Committed: https://crrev.com/341d55881371d22a54560f045cf899034c6c6833 Cr-Commit-Position: refs/heads/master@{#345920}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -30 lines) Patch
M content/browser/indexed_db/indexed_db_browsertest.cc View 3 chunks +17 lines, -10 lines 0 comments Download
M content/browser/indexed_db/indexed_db_class_factory.h View 3 chunks +9 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_class_factory.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.h View 2 chunks +11 lines, -6 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 1 3 chunks +11 lines, -4 lines 0 comments Download
M content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.h View 1 3 chunks +2 lines, -3 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 2 chunks +1 line, -6 lines 0 comments Download
M content/common/indexed_db/indexed_db_constants.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/indexeddb/getall_max_message_size.html View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jsbell
cmumford@ - please take a look?
5 years, 3 months ago (2015-08-26 22:30:04 UTC) #1
cmumford
lgtm % my one comment. https://codereview.chromium.org/1321583002/diff/1/content/common/indexed_db/indexed_db_constants.h File content/common/indexed_db/indexed_db_constants.h (right): https://codereview.chromium.org/1321583002/diff/1/content/common/indexed_db/indexed_db_constants.h#newcode16 content/common/indexed_db/indexed_db_constants.h:16: const size_t kMaxIDBValueSizeInBytes = ...
5 years, 3 months ago (2015-08-26 22:49:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321583002/20001
5 years, 3 months ago (2015-08-27 16:33:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-27 17:58:37 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 17:59:21 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/341d55881371d22a54560f045cf899034c6c6833
Cr-Commit-Position: refs/heads/master@{#345920}

Powered by Google App Engine
This is Rietveld 408576698