IndexedDB: Make getAll() requests fail if result exceeds IPC limits

content/browser/indexed_db/indexed_db_database.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_database.h"
 
 #include <math.h>
 #include <limits>
 #include <set>
 
@@ skipping 114 matching lines @@
   scoped_refptr<IndexedDBCallbacks> callbacks_;
 };
 
 scoped_refptr<IndexedDBDatabase> IndexedDBDatabase::Create(
     const base::string16& name,
     IndexedDBBackingStore* backing_store,
     IndexedDBFactory* factory,
     const Identifier& unique_identifier,
     leveldb::Status* s) {
   scoped_refptr<IndexedDBDatabase> database =
-      new IndexedDBDatabase(name, backing_store, factory, unique_identifier);
+      IndexedDBClassFactory::Get()->CreateIndexedDBDatabase(
+          name, backing_store, factory, unique_identifier);
   *s = database->OpenInternal();
   if (s->ok())
     return database;
   else
     return NULL;
 }
 
 namespace {
 const base::string16::value_type kNoStringVersion[] = {0};
 }
@@ skipping 74 matching lines @@
   return backing_store_->CreateIDBDatabaseMetaData(
       metadata_.name, metadata_.version, metadata_.int_version, &metadata_.id);
 }
 
 IndexedDBDatabase::~IndexedDBDatabase() {
   DCHECK(transactions_.empty());
   DCHECK(pending_open_calls_.empty());
   DCHECK(pending_delete_calls_.empty());
 }
 
+size_t IndexedDBDatabase::GetMaxMessageSizeInBytes() const {
+  return kMaxIDBMessageSizeInBytes;
+}
+
 scoped_ptr<IndexedDBConnection> IndexedDBDatabase::CreateConnection(
     scoped_refptr<IndexedDBDatabaseCallbacks> database_callbacks,
     int child_process_id) {
   scoped_ptr<IndexedDBConnection> connection(
       new IndexedDBConnection(this, database_callbacks));
   connections_.insert(connection.get());
   backing_store_->GrantChildProcessPermissions(child_process_id);
   return connection.Pass();
 }
 
@@ skipping 606 matching lines @@
       if (!return_value.empty() && generated_key) {
         return_value.primary_key = cursor->primary_key();
         return_value.key_path = object_store_metadata.key_path;
       }
     }
 
     if (cursor_type == indexed_db::CURSOR_KEY_ONLY)
       response_size += return_key.size_estimate();
     else
       response_size += return_value.SizeEstimate();
-    if (response_size > IPC::Channel::kMaximumMessageSize) {
-      // TODO(cmumford): Reach this limit more gracefully (crbug.com/478949)
-      break;
+    if (response_size > GetMaxMessageSizeInBytes()) {
+      callbacks->OnError(
+          IndexedDBDatabaseError(blink::WebIDBDatabaseExceptionUnknownError,
+                                 "Maximum IPC message size exceeded."));
+      return;
     }
 
     if (cursor_type == indexed_db::CURSOR_KEY_ONLY)
       found_keys.push_back(return_key);
     else
       found_values.push_back(return_value);
   }
 
   if (cursor_type == indexed_db::CURSOR_KEY_ONLY) {
     // IndexedDBKey already supports an array of values so we can leverage  this
@@ skipping 1091 matching lines @@
     const base::string16& previous_version,
     int64 previous_int_version,
     IndexedDBTransaction* transaction) {
   DCHECK(!transaction);
   IDB_TRACE("IndexedDBDatabase::VersionChangeAbortOperation");
   metadata_.version = previous_version;
   metadata_.int_version = previous_int_version;
 }
 
 }  // namespace content