Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1321573006: Remove env var dep from linux packaging. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang, Michael Moss
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove env var dep from linux packaging. The RPM and DEB packaging scripts expect the environment variable CHROMIUM_BUILD to be set. The build fails mysteriously if this isn't set. This change passes through a string from the gyp build to avoid this. Committed: https://crrev.com/c5ecd7ddc1a1f5a6ee104ea2ffffb82a0db288b7 Cr-Commit-Position: refs/heads/master@{#346201}

Patch Set 1 #

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M chrome/chrome_installer.gypi View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/installer/linux/debian/build.sh View 1 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/installer/linux/rpm/build.sh View 1 4 chunks +7 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (8 generated)
brettw
I think this might be right. Please note that I have no idea how to ...
5 years, 3 months ago (2015-08-27 23:41:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321573006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321573006/1
5 years, 3 months ago (2015-08-27 23:41:32 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 00:43:38 UTC) #6
Michael Moss
LGTM
5 years, 3 months ago (2015-08-28 17:16:17 UTC) #7
Nico
s/me/thestig/ I think this is a good change, but the archive step here https://code.google.com/p/chromium/codesearch#search/&q=%5CbCHROMIUM_BUILD%5Cb%20file:%5C.py%20pcre:yes%20case:yes&sq=package:chromium&type=cs also ...
5 years, 3 months ago (2015-08-28 17:21:39 UTC) #9
brettw
New patch up now that I figured out how to test locally. I forgot to ...
5 years, 3 months ago (2015-08-28 18:06:30 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321573006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321573006/20001
5 years, 3 months ago (2015-08-28 18:07:05 UTC) #12
Lei Zhang
lgtm
5 years, 3 months ago (2015-08-28 18:16:45 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 18:53:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321573006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321573006/20001
5 years, 3 months ago (2015-08-28 18:59:46 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-28 19:04:37 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 19:05:23 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5ecd7ddc1a1f5a6ee104ea2ffffb82a0db288b7
Cr-Commit-Position: refs/heads/master@{#346201}

Powered by Google App Engine
This is Rietveld 408576698