Add Linux build packaging targets to GN

Add Linux build packaging targets to GN

Changes the version processing templates to not implicitly include the chrome version .rc file. This was something I've been meaning to do for a while which was forced by this patch, because it wants to call version.py with no sources or template file. I also had to remove some checks that either a template file or sources were defined (I wasn't aware this was valid to do when I wrote these checks).

The above-mentioned change necessitated referencing the version template file from a number of existing calls.

The version script now explicitly sets the output file with -o. Previously this was the implicit second argument, but this didn't work if there was no template file. -o is the same and it's better to be more explicit anyway.

Added copy rules for xdg-mime related scripts which are required by the installer.

Added a meta "installer" target which links to the Linux installers. This will also be a good place to hook up the Windows installer when we write it.

BUG=525839
TBR=thestig@chromium.org (linux installer), ddorwin@chromium.org (widevine)

Committed: https://crrev.com/a874dccb5c0b7ccfe803a798a585351ce5efccc7
Cr-Commit-Position: refs/heads/master@{#346279}

[brettw, 2015-08-27 23:52:52]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-08-27 23:52:55]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-27 23:53:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311543003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311543003/1

[commit-bot: I haz the power, 2015-08-28 00:38:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-28 00:38:05]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2015-08-28 02:56:21]

I didn't have time to look at this yet, but will look at it tomorrow.

[brettw, 2015-08-28 18:07:16]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-28 18:07:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311543003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311543003/40001

[commit-bot: I haz the power, 2015-08-28 18:59:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-28 18:59:41]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2015-08-28 21:21:45]

lgtm

[brettw, 2015-08-28 22:22:44]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-08-28 22:24:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311543003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311543003/40001

[commit-bot: I haz the power, 2015-08-28 22:54:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-28 22:54:35]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-08-28 23:03:20]

brettw@chromium.org changed reviewers:
+ ddorwin@chromium.org, thestig@chromium.org

[brettw, 2015-08-28 23:04:21]

Lei: I'm not sure you'll care about this. If you do, I'm happy to address any
issues in a follow-up patch.

ddorwin: widevine (mechanical update)

[brettw, 2015-08-28 23:04:24]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-08-28 23:04:24]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1311543003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-08-28 23:05:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311543003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311543003/60001

[Lei Zhang, 2015-08-28 23:17:02]

I trust Dirk to have looked through the installer files.

https://codereview.chromium.org/1311543003/diff/60001/chrome/installer/linux/...
File chrome/installer/linux/BUILD.gn (right):

https://codereview.chromium.org/1311543003/diff/60001/chrome/installer/linux/...
chrome/installer/linux/BUILD.gn:20: # TODO it would be much nicer to have a
build variable so the bot can tell us
With gyp, there's separate targets for the combinations of {.rpm,/deb} +
{stable/beta/unstable/...} so one can build the specific targets as desired.
When one builds all the targets, it builds all the possible combinations.

What extra build variable do you have in mind? Bots can just choose to build the
appropriate targets, right?

https://codereview.chromium.org/1311543003/diff/60001/chrome/installer/linux/...
File chrome/installer/linux/flock_make_package.py (right):

https://codereview.chromium.org/1311543003/diff/60001/chrome/installer/linux/...
chrome/installer/linux/flock_make_package.py:13: #   flock_make_package.py
<lockfile> <shell_script> [<args_to_script>*]
Might be nice to use this with GYP as well for consistency, but whatever.

[brettw, 2015-08-28 23:31:42]

https://codereview.chromium.org/1311543003/diff/60001/chrome/installer/linux/...
File chrome/installer/linux/BUILD.gn (right):

https://codereview.chromium.org/1311543003/diff/60001/chrome/installer/linux/...
chrome/installer/linux/BUILD.gn:20: # TODO it would be much nicer to have a
build variable so the bot can tell us
On 2015/08/28 23:17:02, Lei Zhang wrote:
> With gyp, there's separate targets for the combinations of {.rpm,/deb} +
> {stable/beta/unstable/...} so one can build the specific targets as desired.
> When one builds all the targets, it builds all the possible combinations.
> 
> What extra build variable do you have in mind? Bots can just choose to build
the
> appropriate targets, right?

Yes, in GN you can reference whatever ones you actually want, this is just a
node in the dependency graph that external targets (the general installer one)
refer to to bring in all those into the build.

Basically, I want to have some reasonable behavior for "ninja -C out/foo" where
it builds "everything". GYP has a "suppress_wildcard" feature which kind of
gives this behavior. Here I'm proposing a build var like:
  generate_linux_installer="stable"

[Lei Zhang, 2015-08-28 23:37:49]

On 2015/08/28 23:31:42, brettw wrote:
>
https://codereview.chromium.org/1311543003/diff/60001/chrome/installer/linux/...
> File chrome/installer/linux/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1311543003/diff/60001/chrome/installer/linux/...
> chrome/installer/linux/BUILD.gn:20: # TODO it would be much nicer to have a
> build variable so the bot can tell us
> On 2015/08/28 23:17:02, Lei Zhang wrote:
> > With gyp, there's separate targets for the combinations of {.rpm,/deb} +
> > {stable/beta/unstable/...} so one can build the specific targets as desired.
> > When one builds all the targets, it builds all the possible combinations.
> > 
> > What extra build variable do you have in mind? Bots can just choose to build
> the
> > appropriate targets, right?
> 
> Yes, in GN you can reference whatever ones you actually want, this is just a
> node in the dependency graph that external targets (the general installer one)
> refer to to bring in all those into the build.
> 
> Basically, I want to have some reasonable behavior for "ninja -C out/foo"
where
> it builds "everything". GYP has a "suppress_wildcard" feature which kind of
> gives this behavior. Here I'm proposing a build var like:
>   generate_linux_installer="stable"

I guess this is useful for the internal continuous "official" build waterfall
that builds for a specific channel. One can just build "everything" on those
bots and save a bit of time. I believe the "official-ist" official builders just
builds a given version and package it for all channels. Then the release
managers just push the appropriate packages to users.

[commit-bot: I haz the power, 2015-08-28 23:59:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-29 00:00:04]

Patchset 4 (id:??) landed as
https://crrev.com/a874dccb5c0b7ccfe803a798a585351ce5efccc7
Cr-Commit-Position: refs/heads/master@{#346279}