Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1321463002: Cleanup comments and variable name in ShortcutHelper and AddToHomescreenDialogHelper (Closed)

Created:
5 years, 3 months ago by Lalit Maganti
Modified:
5 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews, mlamouri (slow - plz ping)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup comments and variable name in ShortcutHelper and AddToHomescreenDialogHelper These were accidentally missed comments from https://chromiumcodereview.appspot.com/1288903002/#ps40001 BUG=508627 Committed: https://crrev.com/7cfee5c9d837d66dfbb9b8d552be85c2e735cfe7 Cr-Commit-Position: refs/heads/master@{#345659}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove obsolete comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java View 5 chunks +14 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/shortcut_helper.h View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lalit Maganti
Dan: PTAL. All your comments should be addressed plus some other things I spotted.
5 years, 3 months ago (2015-08-26 13:56:53 UTC) #2
gone
lgtm https://chromiumcodereview.appspot.com/1321463002/diff/1/chrome/browser/android/shortcut_helper.h File chrome/browser/android/shortcut_helper.h (right): https://chromiumcodereview.appspot.com/1321463002/diff/1/chrome/browser/android/shortcut_helper.h#newcode14 chrome/browser/android/shortcut_helper.h:14: // ShortcutHelper in Java. There are no instances ...
5 years, 3 months ago (2015-08-26 18:43:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321463002/20001
5 years, 3 months ago (2015-08-26 19:39:15 UTC) #6
Lalit Maganti
https://codereview.chromium.org/1321463002/diff/1/chrome/browser/android/shortcut_helper.h File chrome/browser/android/shortcut_helper.h (right): https://codereview.chromium.org/1321463002/diff/1/chrome/browser/android/shortcut_helper.h#newcode14 chrome/browser/android/shortcut_helper.h:14: // ShortcutHelper in Java. There are no instances of ...
5 years, 3 months ago (2015-08-26 19:40:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-26 20:44:24 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 20:45:21 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7cfee5c9d837d66dfbb9b8d552be85c2e735cfe7
Cr-Commit-Position: refs/heads/master@{#345659}

Powered by Google App Engine
This is Rietveld 408576698