chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java - Issue 1321463002: Cleanup comments and variable name in ShortcutHelper and AddToHomescreenDialogHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java

Issue 1321463002: Cleanup comments and variable name in ShortcutHelper and AddToHomescreenDialogHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove obsolete comment Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java

index d31737a9f659a011af5a91725ffcb438d7294f87..e01ee23bddabd3ee11df5bae9d26d125cbb12c30 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java

@@ -14,7 +14,7 @@ import org.chromium.chrome.browser.tab.Tab;

import org.chromium.content_public.browser.WebContents;

/**

- * This is a helper class to create shortcuts on the Android home screen.

+ * This class acts as a proxy for AddToHomescreenDialog to interact with C++.

public class AddToHomescreenDialogHelper {

@@ -81,7 +81,7 @@ public class AddToHomescreenDialogHelper {

/**

* Adds a shortcut for the current Tab.

- * @param userRequestedTitle Updated title for the shortcut.

+ * @param userRequestedTitle Title of the shortcut displayed on the homescreen.

public void addShortcut(String userRequestedTitle) {

nativeAddShortcut(mNativeAddToHomescreenDialogHelper, userRequestedTitle);