Attempt to head off OmahaClient ANR

Attempt to head off OmahaClient ANR

* Move code to initialize member variables to when they're actually needed
  by the OmahaClient instead of creating them in onCreate().

* Fully remove the ability to force OmahaClient to send a request to the
  server.  The code that hooked into that was killed ages ago.

BUG=515312
Committed: https://crrev.com/f014ac536d9cd84d87dde53708779f9d20aa0587
Cr-Commit-Position: refs/heads/master@{#346770}

[gone, 2015-09-01 21:46:54]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[gone, 2015-09-01 21:47:08]

dfalcantara@chromium.org changed reviewers:
+ nyquist@chromium.org

[commit-bot: I haz the power, 2015-09-01 21:47:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321393002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321393002/1

[commit-bot: I haz the power, 2015-09-01 22:30:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 22:30:34]

Dry run: This issue passed the CQ dry run.

[nyquist, 2015-09-01 22:32:50]

lgtm

https://codereview.chromium.org/1321393002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaClient.java
(right):

https://codereview.chromium.org/1321393002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaClient.java:297:
generateAndPostRequest(currentTimestamp, sessionID);
So this ignores the return value of the function now. Does it still need to be a
boolean?

[gone, 2015-09-01 22:36:12]

https://codereview.chromium.org/1321393002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaClient.java
(right):

https://codereview.chromium.org/1321393002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaClient.java:297:
generateAndPostRequest(currentTimestamp, sessionID);
On 2015/09/01 22:32:50, nyquist wrote:
> So this ignores the return value of the function now. Does it still need to be
a
> boolean?

There's a call right above this where the boolean return value is actually used;
it's now only used for the case where we can chain the install and the ping
event instead of also for outputting log messages.

[gone, 2015-09-01 22:55:48]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-09-01 22:56:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1321393002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1321393002/1

[commit-bot: I haz the power, 2015-09-01 23:02:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-01 23:03:36]

Patchset 1 (id:??) landed as
https://crrev.com/f014ac536d9cd84d87dde53708779f9d20aa0587
Cr-Commit-Position: refs/heads/master@{#346770}