Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omaha/VersionNumberGetter.java

Issue 1321393002: Attempt to head off OmahaClient ANR (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/omaha/VersionNumberGetter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omaha/VersionNumberGetter.java b/chrome/android/java/src/org/chromium/chrome/browser/omaha/VersionNumberGetter.java
index 071d74e3fce68748147c064f6b642cfbd89ebb99..f6a47daa2cb84061dda32dd60b54167be6de70b1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omaha/VersionNumberGetter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omaha/VersionNumberGetter.java
@@ -21,10 +21,9 @@ public class VersionNumberGetter {
* @return The latest version if we retrieved one from the Omaha server, or "" if we haven't.
*/
public String getLatestKnownVersion(
- Context applicationContext, String prefPackage, String prefLatestVersion) {
+ Context context, String prefPackage, String prefLatestVersion) {
assert Looper.myLooper() != Looper.getMainLooper();
- SharedPreferences prefs = applicationContext.getSharedPreferences(
- prefPackage, Context.MODE_PRIVATE);
+ SharedPreferences prefs = context.getSharedPreferences(prefPackage, Context.MODE_PRIVATE);
return prefs.getString(prefLatestVersion, "");
}
@@ -32,7 +31,7 @@ public class VersionNumberGetter {
* Retrieve the version of Chrome we're using.
* @return The latest version if we retrieved one from the Omaha server, or "" if we haven't.
*/
- public String getCurrentlyUsedVersion(Context applicationContext) {
- return BuildInfo.getPackageVersionName(applicationContext);
+ public String getCurrentlyUsedVersion(Context context) {
+ return BuildInfo.getPackageVersionName(context);
}
}

Powered by Google App Engine
This is Rietveld 408576698