Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1321383002: Revert of Android WebVR implementation, Cardboard 0.5.5 SDK (Closed)

Created:
5 years, 3 months ago by bajones
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android WebVR implementation, Cardboard 0.5.5 SDK (patchset #12 id:220001 of https://codereview.chromium.org/1200303002/ ) Reason for revert: Android team found an incompatibility with the 0.5.5 Cardboard SDK and non-ARM devices. Rolling back until the Cardboard team can address that. Original issue's description: > Android WebVR implementation, Cardboard 0.5.5 SDK > > Previously part of https://codereview.chromium.org/829803003/ > > BUG=389343 > > Committed: https://crrev.com/1d9c45547709e77d599c218d76317895389db129 > Cr-Commit-Position: refs/heads/master@{#342496} > > Committed: https://crrev.com/d9be58be03170c7c82f9c55abc2d21f0f7447c7f > Cr-Commit-Position: refs/heads/master@{#345356} TBR=jochen@chromium.org,jdduke@chromium.org,sievers@chromium.org,tedchoc@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=389343 Committed: https://crrev.com/9763eb99753dc90ae912ebfbee3ba240c37db427 Cr-Commit-Position: refs/heads/master@{#346669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -425 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -8 lines 0 comments Download
M build/config/features.gni View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D content/browser/vr/android/cardboard/cardboard_vr_device.h View 1 chunk +0 lines, -38 lines 0 comments Download
D content/browser/vr/android/cardboard/cardboard_vr_device.cc View 1 chunk +0 lines, -166 lines 0 comments Download
D content/browser/vr/android/cardboard/cardboard_vr_device_provider.h View 1 chunk +0 lines, -33 lines 0 comments Download
D content/browser/vr/android/cardboard/cardboard_vr_device_provider.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M content/browser/vr/vr_device_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/vr/vr_device_manager.cc View 3 chunks +2 lines, -13 lines 0 comments Download
M content/browser/vr/vr_device_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M content/content.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +0 lines, -11 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/input/CardboardVRDevice.java View 1 chunk +0 lines, -88 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bajones
Created Revert of Android WebVR implementation, Cardboard 0.5.5 SDK
5 years, 3 months ago (2015-09-01 16:38:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321383002/1
5 years, 3 months ago (2015-09-01 16:38:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 16:40:02 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9763eb99753dc90ae912ebfbee3ba240c37db427 Cr-Commit-Position: refs/heads/master@{#346669}
5 years, 3 months ago (2015-09-01 16:40:55 UTC) #4
bajones
5 years, 3 months ago (2015-09-01 19:59:36 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1306883009/ by bajones@chromium.org.

The reason for reverting is: Reason for revert was a misunderstanding of issues
that another piece of code was having interacting with the Cardboard SDK. This
code was not exhibiting the same problems, so restoring it while we investigate
the other code's issues further..

Powered by Google App Engine
This is Rietveld 408576698