Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1321343004: Desugar %DefaultConstructorCallSuper partially in parser. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Desugar %DefaultConstructorCallSuper partially in parser. This desugars the loading of the super constructor function using the %GetPrototype runtime function in the parser. The produced code remains the same while fewer parts need to be glued together. R=bmeurer@chromium.org Committed: https://crrev.com/5b938f5234d6d8022573239ed64ee6f14dc0e282 Cr-Commit-Position: refs/heads/master@{#30664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -71 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/parser.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +1 line, -8 lines 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +7 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 3 months ago (2015-09-09 15:11:41 UTC) #1
Benedikt Meurer
LGTM.
5 years, 3 months ago (2015-09-09 17:17:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321343004/1
5 years, 3 months ago (2015-09-09 17:43:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 17:45:49 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 17:46:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b938f5234d6d8022573239ed64ee6f14dc0e282
Cr-Commit-Position: refs/heads/master@{#30664}

Powered by Google App Engine
This is Rietveld 408576698