Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1317033009: [runtime] Remove Runtime::KeyedGetObjectProperty function. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-super-default-construct-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove Runtime::KeyedGetObjectProperty function. R=conradw@chromium.org Committed: https://crrev.com/763c68e4a39148a72f37a8a1c207b6420991794d Cr-Commit-Position: refs/heads/master@{#30675}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M src/runtime/runtime.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/runtime/runtime-object.cc View 4 chunks +8 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Motivation: I am trying to reduce the amount of grab-bag functions on the {Runtime} class. ...
5 years, 3 months ago (2015-09-09 16:17:33 UTC) #1
conradw
LGTM (but as discussed I'm not a committer)
5 years, 3 months ago (2015-09-10 10:38:48 UTC) #2
Benedikt Meurer
LGTM (rubber, rubber)
5 years, 3 months ago (2015-09-10 10:46:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317033009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317033009/1
5 years, 3 months ago (2015-09-10 10:46:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 10:48:57 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 10:49:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/763c68e4a39148a72f37a8a1c207b6420991794d
Cr-Commit-Position: refs/heads/master@{#30675}

Powered by Google App Engine
This is Rietveld 408576698