Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1321313002: Revert of Add tests for Chrome Stability Metrics. (Closed)

Created:
5 years, 3 months ago by Will Harris
Modified:
5 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add tests for Chrome Stability Metrics. (patchset #2 id:20001 of https://codereview.chromium.org/1323703002/ ) Reason for revert: can't use extensions::ExtensionTest in chrome unit_tests, only in extensions_unittests. need to rethink this test. Original issue's description: > Add tests for Chrome Stability Metrics. > > BUG=526198, 467920 > > Committed: https://crrev.com/32a86c2579e167dd1e181676056c202f5191852d > Cr-Commit-Position: refs/heads/master@{#346436} TBR=asvitkine@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=526198, 467920, 526903 Committed: https://crrev.com/c9e354be49d6abb003817f3e5a8a9f8ed17d09fa Cr-Commit-Position: refs/heads/master@{#346567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -162 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/metrics/chrome_stability_metrics_provider.h View 5 chunks +1 line, -17 lines 0 comments Download
M chrome/browser/metrics/chrome_stability_metrics_provider.cc View 6 chunks +42 lines, -38 lines 0 comments Download
D chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Will Harris
Created Revert of Add tests for Chrome Stability Metrics.
5 years, 3 months ago (2015-09-01 04:16:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321313002/1
5 years, 3 months ago (2015-09-01 04:17:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 04:17:36 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 04:18:16 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9e354be49d6abb003817f3e5a8a9f8ed17d09fa
Cr-Commit-Position: refs/heads/master@{#346567}

Powered by Google App Engine
This is Rietveld 408576698