Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1321223002: [turbofan] Remove obsolete unique.h includes in TurboFan. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-isolate-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove obsolete unique.h includes in TurboFan. Now that it is no longer needed, this also removes the invalid inclusion of "object-inl.h" within the "unique.h" header file. Note that this change still leaves 2 violations of that rule in the code, checked with the "tools/check-inline-includes.sh" tool. R=bmeurer@chromium.org Committed: https://crrev.com/c87bd340af676b81aa00288420868ce22b0990f2 Cr-Commit-Position: refs/heads/master@{#30503}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -17 lines) Patch
M src/compiler/common-operator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/interpreter-assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-context-specialization.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-graph.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-inlining.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 3 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/js-operator.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/js-type-feedback-lowering.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/node-matchers.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/frames-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/unique.h View 2 chunks +3 lines, -4 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/interpreter-assembler-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
https://codereview.chromium.org/1321223002/diff/1/src/unique.h File src/unique.h (left): https://codereview.chromium.org/1321223002/diff/1/src/unique.h#oldcode12 src/unique.h:12: #include "src/objects-inl.h" // TODO(everyone): Fix our inl.h crap Please ...
5 years, 3 months ago (2015-08-31 17:09:50 UTC) #1
Benedikt Meurer
LGTM! Ship it! https://codereview.chromium.org/1321223002/diff/1/src/unique.h File src/unique.h (left): https://codereview.chromium.org/1321223002/diff/1/src/unique.h#oldcode12 src/unique.h:12: #include "src/objects-inl.h" // TODO(everyone): Fix our ...
5 years, 3 months ago (2015-08-31 19:06:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321223002/20001
5 years, 3 months ago (2015-09-01 10:29:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-01 10:30:44 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 10:31:06 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c87bd340af676b81aa00288420868ce22b0990f2
Cr-Commit-Position: refs/heads/master@{#30503}

Powered by Google App Engine
This is Rietveld 408576698